Skip to content

case-sensitive-select-expressions - #136

Closed
kieranrimmer wants to merge 1 commit into
stackql:mainfrom
kieranrimmer:bugfix/capitalisation-select-expressions
Closed

kieranrimmer wants to merge 1 commit into
stackql:mainfrom
kieranrimmer:bugfix/capitalisation-select-expressions

Conversation

@kieranrimmer

Copy link
Copy Markdown
Contributor

Description

  • Amended postgres rewriting formatter to surround column names with double quotes.
  • This supports queries against columns that are not uniformly cased, when using a postgres backend.
  • Robot test PG Session Postgres Client V2 Typed Queries un-skipped to demonstrate the fix is successful.

Type of change

  • Bug fix (non-breaking change to fix a bug).
  • Feature (non-breaking change to add functionality).
  • Breaking change.
  • Other (eg: documentation change). Please explain.

Issues referenced.

N/A

Evidence

Please see outcome of test PG Session Postgres Client V2 Typed Queries in Run POSTGRES BACKEND robot mocked functional tests step of Docker Build job in PR actions.

Checklist:

  • A full round of testing has been completed, and there are no test failures as a result of these changes.
  • The changes are covered with functional and/or integration robot testing.
  • The changes work on all supported platforms.

Variations

N/A

Tech Debt

This change does not add new tech debt; rather, it addresses existing tech debt.

Summary:

- Amended `postgres` rewriting formatter to surround column names with double quotes.
- This supports queries against columns that are not uniformly cased, when using a `postgres` backend.
- Robot test `PG Session Postgres Client V2 Typed Queries` un-skipped to demonstrate the fix is successful.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants