Repository navigation
feat(observability): add bearer token, tls config and honor labels/timestamps to scrape config - #1833
Open
ibrahimyesilay wants to merge 1 commit into
Conversation
…mestamps to scrape config The Observability API supports `bearerToken`, `tlsConfig.insecureSkipVerify`, `honorLabels` and `honorTimeStamps` on scrape configs, but the provider did not expose them. Add them to the resource and the data source. - `bearer_token` is sensitive and conflicts with `basic_auth`, since the API rejects both together. - `honor_labels` and `honor_timestamps` are optional and computed, the API returns `false` when they are not set. - A configured `tls_config` with `insecure_skip_verify = false` is kept in state if the API omits the TLS config in its response. relates to stackitcloud#1832
This was referenced Oct 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to #1832
First part of #1832: adds
bearer_token,tls_config.insecure_skip_verify,honor_labelsandhonor_timestampstostackit_observability_scrapeconfig(resource and data source).Based on the review comments on #388 and on what the API returned in my tests (details in #1832):
bearer_tokenis sensitive andConflictsWithbasic_auth— the API rejects both together (at most one of basicAuth or bearerToken must be configured). The description mentions that the API only accepts JWT-formatted tokens.honor_labels/honor_timestampsare optional + computed without a provider default; the API returnsfalsewhen they are not set.tls_configis optional. Ifinsecure_skip_verify = falseis configured and the API leaves the TLS config out of its response, the configured value is kept in state, so there is no inconsistent result.metrics_relabel_configswill follow in a separate PR, as described in #1832.Testing
TestAccResourceMin(observability) extended: the scrape config sets all four fields, checked on create, data source and update (update switchesinsecure_skip_verifytofalse, flips the honor flags and changes the token). Run against a STACKIT project: PASS.make fmt,make lint,make test,make generate-docspass locally.Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)