Skip to content

Load balancer target pool commands improvements #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joaopalet merged 2 commits into from
May 7, 2024
Merged

Load balancer target pool commands improvements #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
047e820
Fix command example
May 7, 2024
e9a8bfe
Add n shorthand to target-name flag
May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/stackit_load-balancer_target-pool_add-target.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ stackit load-balancer target-pool add-target TARGET_POOL_NAME [flags]
-h, --help Help for "stackit load-balancer target-pool add-target"
--ip string Target IP. Must by unique within a target pool. Must be a valid IPv4 or IPv6
--lb-name string Load balancer name
--target-name string Target name
-n, --target-name string Target name
```

### Options inherited from parent commands
Expand Down
2 changes: 1 addition & 1 deletion docs/stackit_load-balancer_target-pool_remove-target.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ stackit load-balancer target-pool remove-target TARGET_POOL_NAME [flags]

```
Remove target with IP 1.2.3.4 from target pool "my-target-pool" of load balancer with name "my-load-balancer"
$ stackit load-balancer target-pool remove-target my-target-pool lb-name my-load-balancer --ip 1.2.3.4
$ stackit load-balancer target-pool remove-target my-target-pool --lb-name my-load-balancer --ip 1.2.3.4
```

### Options
Expand Down
2 changes: 1 addition & 1 deletion internal/cmd/load-balancer/target-pool/add-target/add_target.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ func NewCmd(p *print.Printer) *cobra.Command {

func configureFlags(cmd *cobra.Command) {
cmd.Flags().String(lbNameFlag, "", "Load balancer name")
cmd.Flags().String(targetNameFlag, "", "Target name")
cmd.Flags().StringP(targetNameFlag, "n", "", "Target name")
cmd.Flags().String(ipFlag, "", "Target IP. Must by unique within a target pool. Must be a valid IPv4 or IPv6")

err := flags.MarkFlagsRequired(cmd, lbNameFlag, targetNameFlag, ipFlag)
Expand Down
2 changes: 1 addition & 1 deletion internal/cmd/load-balancer/target-pool/remove-target/remove_target.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
Example: examples.Build(
examples.NewExample(
`Remove target with IP 1.2.3.4 from target pool "my-target-pool" of load balancer with name "my-load-balancer"`,
"$ stackit load-balancer target-pool remove-target my-target-pool lb-name my-load-balancer --ip 1.2.3.4"),
"$ stackit load-balancer target-pool remove-target my-target-pool --lb-name my-load-balancer --ip 1.2.3.4"),
),
RunE: func(cmd *cobra.Command, args []string) error {
ctx := context.Background()
Expand Down