Skip to content

Refac/no issue use generic enum flags for string backed enums#1441

Open
cgoetz-inovex wants to merge 3 commits into
mainfrom
refac/NO-ISSUE-use-generic-enum-flags-for-string-backed-enums
Open

Refac/no issue use generic enum flags for string backed enums#1441
cgoetz-inovex wants to merge 3 commits into
mainfrom
refac/NO-ISSUE-use-generic-enum-flags-for-string-backed-enums

Conversation

@cgoetz-inovex

@cgoetz-inovex cgoetz-inovex commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Description

relates to #1234

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@cgoetz-inovex cgoetz-inovex requested a review from a team as a code owner June 17, 2026 15:04
@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/template 34.38% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/create 81.98% (-0.63%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/list 81.16% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/update 84.73% (-0.34%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/beta/edge/kubeconfig/create 75.97% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/edge/token/create 72.41% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot-policy/list 58.18% (-0.75%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/beta/vpn/connection/create 75.28% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/config/profile/create 45.16% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/config/profile/delete 78.38% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/config/profile/set 34.48% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/config/unset 35.16% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/curl 51.65% (-1.54%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/dns/record-set/create 55.38% (-2.59%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/dns/record-set/list 69.31% (-0.30%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/dns/zone/create 56.92% (-1.90%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/dns/zone/list 70.65% (-0.32%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/create 50.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/wrappingkey/create 48.98% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/mongodbflex/instance/create 59.60% (-0.40%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/mongodbflex/instance/update 64.34% (-0.27%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/mongodbflex/user/create 58.82% (-0.79%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/mongodbflex/user/update 46.81% (-1.11%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/network-area/routingtable/route/create 64.38% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/organization/member/list 55.93% (-0.73%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/postgresflex/instance/create 59.60% (-0.40%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/postgresflex/instance/update 65.12% (-0.27%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/postgresflex/user/create 59.18% (-0.82%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/postgresflex/user/update 44.44% (-1.21%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/project/member/list 54.69% (-0.70%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/server/create 70.80% (-0.26%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/ske/kubeconfig/create 31.71% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/volume/backup/create 43.06% (-0.78%) 👎
github.com/stackitcloud/stackit-cli/internal/pkg/flags 65.16% (-2.90%) 👎
github.com/stackitcloud/stackit-cli/internal/pkg/globalflags 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/testutils 49.69% (-0.65%) 👎
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/template/template.go 34.38% (ø) 32 11 21
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/create/create.go 81.98% (-0.63%) 111 (-4) 91 (-4) 20 👎
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/list/list.go 81.16% (ø) 69 56 13
github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/update/update.go 84.73% (-0.34%) 131 (-3) 111 (-3) 20 👎
github.com/stackitcloud/stackit-cli/internal/cmd/beta/edge/kubeconfig/create/create.go 75.97% (ø) 129 98 31
github.com/stackitcloud/stackit-cli/internal/cmd/beta/edge/token/create/create.go 72.41% (ø) 87 63 24
github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot-policy/list/list.go 58.18% (-0.75%) 55 (-1) 32 (-1) 23 👎
github.com/stackitcloud/stackit-cli/internal/cmd/beta/vpn/connection/create/create.go 75.28% (ø) 89 67 22
github.com/stackitcloud/stackit-cli/internal/cmd/config/unset/unset.go 35.16% (ø) 128 45 83
github.com/stackitcloud/stackit-cli/internal/cmd/curl/curl.go 51.65% (-1.54%) 91 (-3) 47 (-3) 44 👎
github.com/stackitcloud/stackit-cli/internal/cmd/dns/record-set/create/create.go 55.38% (-2.59%) 65 (-4) 36 (-4) 29 👎
github.com/stackitcloud/stackit-cli/internal/cmd/dns/record-set/list/list.go 69.31% (-0.30%) 101 (-1) 70 (-1) 31 👎
github.com/stackitcloud/stackit-cli/internal/cmd/dns/zone/create/create.go 56.92% (-1.90%) 65 (-3) 37 (-3) 28 👎
github.com/stackitcloud/stackit-cli/internal/cmd/dns/zone/list/list.go 70.65% (-0.32%) 92 (-1) 65 (-1) 27 👎
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/create/create.go 50.00% (ø) 50 25 25
github.com/stackitcloud/stackit-cli/internal/cmd/kms/wrappingkey/create/create.go 48.98% (ø) 49 24 25
github.com/stackitcloud/stackit-cli/internal/cmd/mongodbflex/instance/create/create.go 59.60% (-0.40%) 99 (-1) 59 (-1) 40 👎
github.com/stackitcloud/stackit-cli/internal/cmd/mongodbflex/instance/update/update.go 64.34% (-0.27%) 129 (-1) 83 (-1) 46 👎
github.com/stackitcloud/stackit-cli/internal/cmd/mongodbflex/user/create/create.go 58.82% (-0.79%) 51 (-1) 30 (-1) 21 👎
github.com/stackitcloud/stackit-cli/internal/cmd/mongodbflex/user/update/update.go 46.81% (-1.11%) 47 (-1) 22 (-1) 25 👎
github.com/stackitcloud/stackit-cli/internal/cmd/network-area/routingtable/route/create/create.go 64.38% (ø) 73 47 26
github.com/stackitcloud/stackit-cli/internal/cmd/organization/member/list/list.go 55.93% (-0.73%) 59 (-1) 33 (-1) 26 👎
github.com/stackitcloud/stackit-cli/internal/cmd/postgresflex/instance/create/create.go 59.60% (-0.40%) 99 (-1) 59 (-1) 40 👎
github.com/stackitcloud/stackit-cli/internal/cmd/postgresflex/instance/update/update.go 65.12% (-0.27%) 129 (-1) 84 (-1) 45 👎
github.com/stackitcloud/stackit-cli/internal/cmd/postgresflex/user/create/create.go 59.18% (-0.82%) 49 (-1) 29 (-1) 20 👎
github.com/stackitcloud/stackit-cli/internal/cmd/postgresflex/user/update/update.go 44.44% (-1.21%) 45 (-1) 20 (-1) 25 👎
github.com/stackitcloud/stackit-cli/internal/cmd/project/member/list/list.go 54.69% (-0.70%) 64 (-1) 35 (-1) 29 👎
github.com/stackitcloud/stackit-cli/internal/cmd/server/create/create.go 70.80% (-0.26%) 113 (-1) 80 (-1) 33 👎
github.com/stackitcloud/stackit-cli/internal/cmd/volume/backup/create/create.go 43.06% (-0.78%) 72 (-1) 31 (-1) 41 👎
github.com/stackitcloud/stackit-cli/internal/pkg/flags/string_enum.go 78.00% (-17.24%) 50 (+8) 39 (-1) 11 (+9) 💀
github.com/stackitcloud/stackit-cli/internal/pkg/flags/string_enumslice.go 83.64% (-12.11%) 55 (+8) 46 (+1) 9 (+7) 💀
github.com/stackitcloud/stackit-cli/internal/pkg/globalflags/global_flags.go 0.00% (ø) 26 0 26
github.com/stackitcloud/stackit-cli/internal/pkg/testutils/parse_input.go 79.55% (+0.06%) 44 (+5) 35 (+4) 9 (+1) 👍
github.com/stackitcloud/stackit-cli/internal/pkg/testutils/testutils.go 0.00% (ø) 65 (+5) 0 65 (+5)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb/template/template_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/cdn/distribution/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/edge/kubeconfig/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/sfs/snapshot-policy/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/config/profile/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/config/profile/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/config/profile/set/set_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/curl/curl_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/dns/record-set/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/dns/record-set/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/dns/zone/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/dns/zone/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/mongodbflex/instance/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/mongodbflex/instance/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/mongodbflex/user/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/mongodbflex/user/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/network-area/routingtable/route/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/organization/member/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/postgresflex/instance/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/postgresflex/instance/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/postgresflex/user/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/postgresflex/user/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/project/member/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/server/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/ske/kubeconfig/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/volume/backup/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/flags/string_enum_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/flags/string_enumslice_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cgoetz-inovex