Add extra label config to add labels to all ALBs and Certificates#10
Add extra label config to add labels to all ALBs and Certificates#10dergeberl wants to merge 3 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
26b1b98 to
c04152f
Compare
…verwrtiing is not possible; Use Const for the ingress-class-uid label
|
FYI: I also use now the |
| ephemeralAddress = new(true) | ||
| } | ||
|
|
||
| labels := map[string]string{ |
There was a problem hiding this comment.
Is this a breaking change (and is it intentional)? The old code used the bare string ingress-class-uid as the label key. The new code replaces it with the constant LabelIngressClassUID, which expands to alb-ingress-controller-ingress-class-uid.
How to categorize this PR?
/kind enhancement
/cc @stackitcloud/ske-infrastructure
What this PR does / why we need it:
This PR adds the possibility to add extra labels to the ALB and Certificates. This is analog to the NLBs on the cloud-provider-stackit.