Skip to content

docs: Fix cockpit installation guide#236

Merged
sbernauer merged 1 commit into
mainfrom
docs/fix-cockpit-installation
Apr 29, 2024
Merged

docs: Fix cockpit installation guide#236
sbernauer merged 1 commit into
mainfrom
docs/fix-cockpit-installation

Conversation

@sbernauer
Copy link
Copy Markdown
Member

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@sbernauer sbernauer self-assigned this Apr 26, 2024
Copy link
Copy Markdown
Contributor

@fhennig fhennig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question, but rest looks sensible

Comment thread web/src/api/schema.d.ts
@sbernauer sbernauer requested a review from fhennig April 29, 2024 11:46
Copy link
Copy Markdown
Contributor

@fhennig fhennig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it

@sbernauer sbernauer added this pull request to the merge queue Apr 29, 2024
Merged via the queue into main with commit cfda302 Apr 29, 2024
@sbernauer sbernauer deleted the docs/fix-cockpit-installation branch April 29, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants