Relax the length constraints of cluster, role and role group name#1222
Conversation
maltesander
left a comment
There was a problem hiding this comment.
LGTM, there are some stale compile asserts not using the qualified_role_group_name assert "The string <cluster_name>-<hash>..." but "The string <cluster_name>-<role_name>-<role_group_name>...":
- role_group_config_map
- stateful_set_name
- listener_name
adwk67
left a comment
There was a problem hiding this comment.
Testing with superset/resources test that failed with current smooth-op branch.
Nit: does this change behaviour - e.g. where previously a name exceeding the allowed overall length would result in an error, the name is now silently adapted? If so, we should add something to the change log, along with the other breaking changes.
If a name exceeded the length limit, then the cluster spec was not rejected by the operator. It just applied the resources until Kubernetes complained. Usually, some Services and ConfigMaps were applied but the StatefulSet was not. The operator then went into an error loop. This is in my opinion not a change but a new feature. The operator can now handle more specs than before. |
Description
Relax the length constraints of cluster, role and role group name
Some operators use long role names like
dagprocessorandmiddlemanager. Increasing the length of role names would require decreasing the length of cluster or role group name. These length constraints are already so tight that they could break existing cluster configurations. Instead, the length constraints were relaxed:ClusterNameis now up to 40 characters,RoleNameandRoleGroupNameare up to 63 characters each, according to RFC 1123 label names. In turn, if the qualified role group name length exceeds its limit of 52 characters, it is truncated and a hash is added.Definition of Done Checklist
Author
Reviewer
Acceptance