-
Notifications
You must be signed in to change notification settings - Fork 514
Customizable ports #962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Customizable ports #962
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
afae79b
Customizable ports
N2D4 8a76453
Update
N2D4 4433317
fix types
N2D4 915252d
fix lint
N2D4 f4e3b9a
Merge branch 'dev' into customizable-ports
N2D4 eb5662c
Update title
N2D4 a20ccaa
fix tests
N2D4 8e880cc
more fixes
N2D4 4caefb1
more fixes
N2D4 0550e2f
fix
N2D4 60410a3
fix
N2D4 f441c50
better
N2D4 2c04b0a
fix
N2D4 abdad07
No more config twiddling
N2D4 faf2157
chore(docs): update TOC
N2D4 184e9e6
Rename envvar
N2D4 d6ed716
fixes
N2D4 7c4c8ba
Merge branch 'dev' into customizable-ports
N2D4 8400777
more
N2D4 5c2a55c
fixes
N2D4 51860cc
fixes
N2D4 3774341
fixes
N2D4 14eafbb
fix
N2D4 f1d479a
more test fixes
N2D4 30f5592
fix
N2D4 52c398d
fix
N2D4 7ccc830
fix wildcard domains test
N2D4 cab12f0
stuff
N2D4 434d1bf
fix emulator
N2D4 c796ebf
Customizable ports docs
N2D4 0f5c776
disable emulator workflow
N2D4 7c699a5
improve process names
N2D4 8e4574e
Merge dev into customizable-ports
N2D4 f42efeb
Merge dev into customizable-ports
N2D4 75c2595
Merge branch 'dev' into customizable-ports
N2D4 76ef55f
REmove ppr
N2D4 ba0ec30
Merge branch 'dev' into customizable-ports
N2D4 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix emulator
- Loading branch information
commit 434d1bfc6364570524db43204cde3156fbd0c322
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,7 +36,7 @@ services: | |
| STACK_SVIX_API_KEY: "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpYXQiOjE2NTUxNDA2MzksImV4cCI6MTk3MDUwMDYzOSwibmJmIjoxNjU1MTQwNjM5LCJpc3MiOiJzdml4LXNlcnZlciIsInN1YiI6Im9yZ18yM3JiOFlkR3FNVDBxSXpwZ0d3ZFhmSGlyTXUifQ.En8w77ZJWbd0qrMlHHupHUB-4cx17RfzFykseg95SUk" | ||
| NEXT_PUBLIC_STACK_INBUCKET_WEB_URL: "http://localhost:32203" | ||
| STACK_EMAIL_HOST: "inbucket" | ||
| STACK_EMAIL_PORT: 8129 | ||
| STACK_EMAIL_PORT: 2500 | ||
| STACK_EMAIL_SECURE: "false" | ||
| STACK_EMAIL_USERNAME: "none" | ||
| STACK_EMAIL_PASSWORD: "none" | ||
|
|
@@ -81,15 +81,15 @@ services: | |
|
|
||
| db: | ||
| image: postgres:15 | ||
| command: ["postgres", "-c", "port=8128"] | ||
| command: ["postgres", "-c"] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| environment: | ||
| POSTGRES_USER: postgres | ||
| POSTGRES_PASSWORD: PASSWORD-PLACEHOLDER--uqfEC1hmmv | ||
| POSTGRES_DB: stackframe | ||
| volumes: | ||
| - postgres-data:/var/lib/postgresql/data | ||
| healthcheck: | ||
| test: ["CMD-SHELL", "pg_isready -p 8128 -d stackframe"] | ||
| test: ["CMD-SHELL", "pg_isready -p 5432 -d stackframe"] | ||
| interval: 5s | ||
| timeout: 10s | ||
| retries: 5 | ||
|
|
@@ -99,8 +99,8 @@ services: | |
| inbucket: | ||
| image: inbucket/inbucket:latest | ||
| environment: | ||
| INBUCKET_SMTP_ADDR: ":8129" | ||
| INBUCKET_POP3_ADDR: ":8130" | ||
| INBUCKET_SMTP_ADDR: ":2500" | ||
| INBUCKET_POP3_ADDR: ":1100" | ||
| ports: | ||
| - 32203:9000 | ||
| volumes: | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PostgreSQL command is incomplete and will cause the container to fail on startup. The
-cflag requires a configuration parameter but none is provided.View Details
Analysis
Incomplete PostgreSQL -c flag causes container startup failure
What fails: PostgreSQL container in docker/emulator/docker.compose.yaml line 84 has incomplete command
["postgres", "-c"]causing startup failure with "postgres: option requires an argument -- 'c'" errorHow to reproduce:
Result: Container exits immediately with non-zero exit code. PostgreSQL fails with "postgres: option requires an argument -- 'c'" per PostgreSQL server documentation
Expected: Container should start successfully. Git history shows this was originally
["postgres", "-c", "port=8128"]butport=8128parameter was accidentally removed while leaving the incomplete-cflag