Refactor feedback tests for improved clarity and consistency

- Updated feedback test cases to ensure consistent email and message length checks. - Removed optional chaining in assertions for better readability and reliability. - Enhanced test coverage for feedback submissions, ensuring accurate validation of email and message content.
stack-auth · mantrakp04 · Apr 14, 2026 · Mar 20, 2026 · Mar 27, 2026 · Mar 27, 2026
commit 86f480c86fe27c8a074fd7d86201edd626bbc5ed
diff --git a/apps/e2e/tests/backend/endpoints/api/v1/internal/feedback.test.ts b/apps/e2e/tests/backend/endpoints/api/v1/internal/feedback.test.ts
@@ -51,18 +51,19 @@ describe("POST /api/v1/internal/feedback", () => {
     `);
 
     const emails = await waitForOutboxEmailWithStatus(subject, "sent");
-    expect(emails[0]?.to).toMatchObject({
+    expect(emails).toHaveLength(1);
+    expect(emails[0].to).toMatchObject({
       type: "custom-emails",
       emails: ["team@stack-auth.com"],
     });
 
     const messages = await recipientMailbox.waitForMessagesWithSubject(subject);
     expect(messages).toHaveLength(1);
-    expect(messages[0]?.subject).toBe(subject);
-    expect(messages[0]?.body?.text).toContain("Support Tester");
-    expect(messages[0]?.body?.text).toContain(senderEmail);
-    expect(messages[0]?.body?.text).toContain(signInResult.userId);
-    expect(messages[0]?.body?.text).toContain("Authenticated feedback from the dashboard.");
+    expect(messages[0].subject).toBe(subject);
+    expect(messages[0].body?.text).toContain("Support Tester");
+    expect(messages[0].body?.text).toContain(senderEmail);
+    expect(messages[0].body?.text).toContain(signInResult.userId);
+    expect(messages[0].body?.text).toContain("Authenticated feedback from the dashboard.");
   });
 
   it("should send feedback without authentication (dev tool)", async ({ expect }) => {
@@ -92,16 +93,17 @@ describe("POST /api/v1/internal/feedback", () => {
     `);
 
     const emails = await waitForOutboxEmailWithStatus(subject, "sent");
-    expect(emails[0]?.to).toMatchObject({
+    expect(emails).toHaveLength(1);
+    expect(emails[0].to).toMatchObject({
       type: "custom-emails",
       emails: ["team@stack-auth.com"],
     });
 
     const messages = await recipientMailbox.waitForMessagesWithSubject(subject);
     expect(messages).toHaveLength(1);
-    expect(messages[0]?.body?.text).toContain("Dev Tool User");
-    expect(messages[0]?.body?.text).toContain("devtool-user@example.com");
-    expect(messages[0]?.body?.text).toContain("Unauthenticated feedback from the dev tool.");
+    expect(messages[0].body?.text).toContain("Dev Tool User");
+    expect(messages[0].body?.text).toContain("devtool-user@example.com");
+    expect(messages[0].body?.text).toContain("Unauthenticated feedback from the dev tool.");
   });
 
   it("should send bug reports with correct label", async ({ expect }) => {
@@ -130,14 +132,15 @@ describe("POST /api/v1/internal/feedback", () => {
     `);
 
     const emails = await waitForOutboxEmailWithStatus(subject, "sent");
-    expect(emails[0]?.to).toMatchObject({
+    expect(emails).toHaveLength(1);
+    expect(emails[0].to).toMatchObject({
       type: "custom-emails",
       emails: ["team@stack-auth.com"],
     });
 
     const messages = await recipientMailbox.waitForMessagesWithSubject(subject);
     expect(messages).toHaveLength(1);
-    expect(messages[0]?.subject).toBe("[Bug Report] bug@example.com");
+    expect(messages[0].subject).toBe("[Bug Report] bug@example.com");
   });
 
   it("should reject invalid payloads", async ({ expect }) => {

diff --git a/packages/template/src/dev-tool/dev-tool-indicator.tsx b/packages/template/src/dev-tool/dev-tool-indicator.tsx
@@ -28,6 +28,7 @@ function useFetchInterceptor(addApiLog: (entry: ApiLogEntry) => void, addEventLo
   useEffect(() => {
     if (typeof window === 'undefined') return;
     // Avoid double-patching (e.g. during HMR remounts)
+    // Cast to any: adding a runtime-only property (__stackDevToolPatched) to window.fetch which isn't in DOM types
     if ((window.fetch as any).__stackDevToolPatched) return;
 
     const originalFetch = window.fetch;