Better error messages for tests

stack-auth · N2D4 · Feb 16, 2026 · Feb 2, 2026 · Feb 2, 2026 · Feb 2, 2026
commit cbe7611e84ce595bf3511f44b07fd874b179d997
diff --git a/apps/e2e/tests/backend/endpoints/api/v1/external-db-sync-advanced.test.ts b/apps/e2e/tests/backend/endpoints/api/v1/external-db-sync-advanced.test.ts
@@ -1,9 +1,9 @@
-import { wait } from "@stackframe/stack-shared/dist/utils/promises";
 import { StackAssertionError } from "@stackframe/stack-shared/dist/utils/errors";
+import { wait } from "@stackframe/stack-shared/dist/utils/promises";
 import { Client } from 'pg';
 import { afterAll, beforeAll, describe, expect } from 'vitest';
 import { test } from '../../../../helpers';
-import { InternalApiKey, Project, User, backendContext, niceBackendFetch } from '../../../backend-helpers';
+import { InternalApiKey, User, backendContext, niceBackendFetch } from '../../../backend-helpers';
 import {
   HIGH_VOLUME_TIMEOUT,
   POSTGRES_HOST,
@@ -39,18 +39,17 @@
       query: "SELECT primary_email, display_name FROM users WHERE primary_email = {email:String}",
       params: { email },
     });
-    if (
-      response.status === 200
-      && Array.isArray(response.body?.result)
-      && response.body.result.length === 1
-      && response.body.result[0]?.display_name === expectedDisplayName
-    ) {
+    expect(response).toMatchObject({
+      status: 200,
+    });
+    if (response.body.result.length === 1) {
+      expect(response.body.result[0].display_name).toBe(expectedDisplayName);
       return response;
     }
     await wait(intervalMs);
  }

  throw new StackAssertionError(`Timed out waiting for ClickHouse user ${email} to sync.`);
 }

 describe.sequential('External DB Sync - Advanced Tests', () => {

diff --git a/apps/e2e/tests/backend/endpoints/api/v1/external-db-sync-basics.test.ts b/apps/e2e/tests/backend/endpoints/api/v1/external-db-sync-basics.test.ts
@@ -1,5 +1,5 @@
-import { wait } from "@stackframe/stack-shared/dist/utils/promises";
 import { StackAssertionError } from "@stackframe/stack-shared/dist/utils/errors";
+import { wait } from "@stackframe/stack-shared/dist/utils/promises";
 import { afterAll, beforeAll, describe, expect } from 'vitest';
 import { test } from '../../../../helpers';
 import { Project, User, niceBackendFetch } from '../../../backend-helpers';
@@ -9,7 +9,6 @@
   createProjectWithExternalDb as createProjectWithExternalDbRaw,
   verifyInExternalDb,
   verifyNotInExternalDb,
-  waitForCondition,
   waitForSyncedData,
   waitForSyncedDeletion,
   waitForTable
@@ -35,12 +34,11 @@
         email,
       },
     });
-    if (
-      response.status === 200
-      && Array.isArray(response.body?.result)
-      && response.body.result.length === 1
-      && response.body.result[0]?.display_name === expectedDisplayName
-    ) {
+    expect(response).toMatchObject({
+      status: 200,
+    });
+    if (response.body.result.length === 1) {
+      expect(response.body.result[0].display_name).toBe(expectedDisplayName);
       return response;
     }
     await wait(intervalMs);
@@ -48,7 +46,7 @@

  throw new StackAssertionError(`Timed out waiting for ClickHouse user ${email} to sync.`);
 }

 async function waitForClickhouseUserDeletion(email: string) {
  const timeoutMs = 180_000;
  const intervalMs = 2_000;
@@ -61,12 +59,11 @@
         email,
       },
     });
-    if (
-      response.status === 200
-      && Array.isArray(response.body?.result)
-      && response.body.result.length === 0
-    ) {
-      return;
+    expect(response).toMatchObject({
+      status: 200,
+    });
+    if (response.body.result.length === 0) {
+      return response;
     }
     await wait(intervalMs);
   }
@@ -74,7 +71,7 @@
  throw new StackAssertionError(`Timed out waiting for ClickHouse user ${email} to be deleted.`);
 }

 // Run tests sequentially to avoid concurrency issues with shared backend state
 describe.sequential('External DB Sync - Basic Tests', () => {
  let dbManager: TestDbManager;
  const createProjectWithExternalDb = (