Skip to content

Enable nullable on NetConf/Scp/SshClient#1392

Merged
Rob-Hague merged 7 commits into
sshnet:developfrom
mus65:nullable
May 21, 2024
Merged

Enable nullable on NetConf/Scp/SshClient#1392
Rob-Hague merged 7 commits into
sshnet:developfrom
mus65:nullable

Conversation

@mus65

@mus65 mus65 commented May 5, 2024

Copy link
Copy Markdown
Contributor

Followup #1339

@mus65

mus65 commented May 5, 2024

Copy link
Copy Markdown
Contributor Author

CI failure looks unrelated. Windows works and I can't reproduce it locally on Linux.

Comment thread src/Renci.SshNet/ScpClient.cs Outdated
mus65 added 3 commits May 20, 2024 18:00
since the libraries are missing a lot of nullable attributes
in the old frameworks, this causes a lot of false positive
nullable warnings.

Simply disable these warnings for old frameworks.

@Rob-Hague Rob-Hague left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Rob-Hague Rob-Hague merged commit b4722b8 into sshnet:develop May 21, 2024
@mus65 mus65 deleted the nullable branch September 14, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants