Skip to content

Use conftest file in db subdir for db related fixtures#1613

Open
yzernik wants to merge 1 commit into
masterfrom
move_db_fixtures_to_separate_conftest_file
Open

Use conftest file in db subdir for db related fixtures#1613
yzernik wants to merge 1 commit into
masterfrom
move_db_fixtures_to_separate_conftest_file

Conversation

@yzernik

@yzernik yzernik commented Oct 16, 2021

Copy link
Copy Markdown
Collaborator

This is currently failing, because mypy complains about the duplicate module name of "conftest".

-------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                      3922   1795    571     23    50%
py38 run-test: commands[3] | coverage html
py38 run-test: commands[4] | pre-commit install -f --install-hooks
pre-commit installed at .git/hooks/pre-commit
py38 run-test: commands[5] | pre-commit run --all-files
Check Yaml...............................................................Passed
Debug Statements (Python)................................................Passed
Fix requirements.txt.....................................................Passed
check BOM - deprecated: use fix-byte-order-marker........................Passed
Check for merge conflicts................................................Passed
flake8...................................................................Passed
autopep8.................................................................Passed
Reorder python imports...................................................Passed
mypy.....................................................................Failed
- hook id: mypy
- exit code: 2

tests/db/conftest.py: error: Duplicate module named 'conftest' (also at 'tests/admin/conftest.py')
Found 1 error in 1 file (checked 113 source files)

autoflake................................................................Passed
Insert license in comments...............................................Passed
ERROR: InvocationError for command /home/yzernik/work/squeaknode/.tox/py38/bin/pre-commit run --all-files (exited with code 1)
_______________________________________________________ summary _______________________________________________________
SKIPPED:  py36: InterpreterNotFound: python3.6
SKIPPED:  py37: InterpreterNotFound: python3.7
ERROR:   py38: commands failed
make: *** [Makefile:14: test] Error 1

@codecov

codecov Bot commented Oct 16, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1613 (1695094) into master (661c85b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1613   +/-   ##
=======================================
  Coverage   53.64%   53.64%           
=======================================
  Files          75       75           
  Lines        3922     3922           
  Branches      285      285           
=======================================
  Hits         2104     2104           
+ Misses       1795     1794    -1     
- Partials       23       24    +1
Impacted Files Coverage Δ
squeaknode/node/squeak_controller.py 35.47% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 661c85b...1695094. Read the comment docs.

@yzernik yzernik added the wip label Oct 16, 2021
@yzernik

yzernik commented Nov 28, 2021

Copy link
Copy Markdown
Collaborator Author

Seems to be a known issue: python/mypy#4008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

wip

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@yzernik