This repository was archived by the owner on Aug 23, 2025. It is now read-only.
Move vis modal into sidebar#869
Merged
Merged
Conversation
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves vis modal into sidebar. This allows the user to see the chart while selecting fields, and also establishes a new pattern/space for expanding on user input.
Eventually tags, sharing query properties can be moved into this sidebar, with a sort of side-tab strip allowing the sidebar to be toggled on and off.
Note that this is going into the v6 branch so that all UI changes launch at once.
@eladeyal-intel curious what your thoughts since this kind of addresses #741