docs: rewrite README with examples, API reference, use cases - #1
Merged
Conversation
- Full README from shadow work; final review fixes - Use PERCENTILE for rolling median (MEDIAN2 is not window-capable) - Soften ARM64 claim pending hardware verification Made-with: Cursor
Contributor
~/Documents/sqlmath$ python setup.py sdist
Traceback (most recent call last):
File "C:\Users\kai.zhu\Documents\sqlmath\setup.py", line 647, in <module>
main()
File "C:\Users\kai.zhu\Documents\sqlmath\setup.py", line 617, in main
build_sdist("dist")
File "C:\Users\kai.zhu\Documents\sqlmath\setup.py", line 403, in build_sdist
build_pkg_info()
File "C:\Users\kai.zhu\Documents\sqlmath\setup.py", line 387, in build_pkg_info
data += file1.read().strip() + "\n"
^^^^^^^^^^^^
File "C:\Python312\Lib\encodings\cp1252.py", line 23, in decode
return codecs.charmap_decode(input,self.errors,decoding_table)[0]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
UnicodeDecodeError: 'charmap' codec can't decode byte 0x9d in position 11173: character maps to <undefined> |
…aths in CI - setup.py: open pyproject.toml, README.md, MANIFEST.in, PKG-INFO, and sdist temp script with encoding=utf-8 (fixes cp1252 UnicodeDecodeError when embedding README in PKG-INFO on Windows). - .ci.sh: resolve libomp via Homebrew ARM, Intel, or HOMEBREW_PREFIX; remove stale dylibs before copy; use pip show lightgbm for site-packages. - PKG-INFO: regenerated from current README.md. Made-with: Cursor
…ghtgbm paths in CI" This reverts commit 41ec7aa.
Resolve README: keep rewritten intro and badges, restore Status table and maintainer sections from upstream; dedupe Changelog block. Made-with: Cursor
Made-with: Cursor
This reverts commit f85c4af.
Contributor
Author
Following up on your previous comment:
Merge readiness (FYI)
Let me know if you'd like to change anything! |
- sqlmath-npm - bugfix - Fix missing lib_lightgbm pre-built libraries in npm-package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complete README rewrite: value proposition, quick start (Python, Node, browser), categorized SQL functions, LightGBM (with Kaggle notebook link), use cases, comparison table, Python API reference, platform notes, and build instructions.
Review fixes (pre-merge):
PERCENTILE(..., 50) OVER(...)—MEDIAN2is aggregate-only and cannot be used as a window functionTest plan
npm run test --fast(maintainer)sqlmathsource and live Python runsMade with Cursor