Repository navigation
Fix hanging when deleting large number of records (#856) - #870
Merged
Merged
Conversation
When trying to delete all records or large number of them (~5000) (selecting them and pressing Delete Record on Data tab), it takes too much time to execute this operation due to large number of queries like `DELETE * FROM 'table' WHERE '_rowid_' = id`.
Member
|
Awesome. 😄 Both @MKleusberg and I are taking a short break to recharge (back next week), so we'll get to this then. Are you ok to figure out the Travis CI failure problem until then? |
Member
|
This is travis CI that breaks stuff during pre-build scenario. |
Shell commands which do not produce any output are executed only for 10 minutes in Travis CI unless `travis_wait` option is specified (more at https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received). It caused the build to fail because of `-qq` options which are removed in this commit.
Member
|
Thank you @prutz1311, this should really help. 😄 @chrisjlocke Any interest in testing out the record deletion speed with tomorrow's nightly build? |
Member
|
Surely can. |
vtronko
pushed a commit
that referenced
this pull request
Dec 29, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to delete all records or large number of
them (~5000) (selecting them and pressing Delete Record on Data tab), it
takes too much time to execute this operation due to large number of
queries like
DELETE * FROM 'table' WHERE '_rowid_' = id.