Skip to content

Fix empty cells not being copied properly - #825

Merged
vtronko merged 1 commit into
sqlitebrowser:masterfrom
vtronko:master
Oct 15, 2016
Merged

vtronko merged 1 commit into
sqlitebrowser:masterfrom
vtronko:master

Conversation

@vtronko

@vtronko vtronko commented Oct 13, 2016

Copy link
Copy Markdown
Member

No description provided.

@vtronko
vtronko force-pushed the master branch 2 times, most recently from 811d43a to ee8adab Compare October 13, 2016 20:23
@vtronko

vtronko commented Oct 13, 2016

Copy link
Copy Markdown
Member Author

Everyone hail to clang.

With this commit, we start to handle empty and NULL single cell
selections in a special way. Well, there's nothing special about it.
We just push them to inner buffer and clear outer clipboard. That's it.

NB: possible side effect might appear if you copy empty value,
then select some text and paste your empty value here. Nothing will
happen with text though, because, well, we wiped clipboard.

Plus, it fixes single-cell multiline text copy-pasting (sqlitebrowser#541)
@vtronko

vtronko commented Oct 15, 2016

Copy link
Copy Markdown
Member Author

It's awesome how I need to rewrite one-line
m_buffer.push_back({data.toByteArray()});
as

QByteArray lst;
lst << data.toByteArray();
m_buffer.push_back(lst);

Because clang is mad.

@vtronko
vtronko merged commit 312c29b into sqlitebrowser:master Oct 15, 2016
vtronko added a commit that referenced this pull request Dec 29, 2016
With this commit, we start to handle empty and NULL single cell
selections in a special way. Well, there's nothing special about it.
We just push them to inner buffer and clear outer clipboard. That's it.

NB: possible side effect might appear if you copy empty value,
then select some text and paste your empty value here. Nothing will
happen with text though, because, well, we wiped clipboard.

Plus, it fixes single-cell multiline text copy-pasting (#541)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants