Repository navigation
Fix incorrect scrollbar size on macOS with Qt5 - #810
Merged
justinclift merged 1 commit intoOct 8, 2016
Merged
Conversation
Building the project with Qt5 on macOS and browsing a huge table, the scrollbar height was smaller than necessary. Scrolling to the end, some rows were not showing up. This was caused by the default verticall scroll mode, which is set to ScrollPerPixel on macOS, and ScrollPerItem on other systems.
justinclift
reviewed
Oct 8, 2016
justinclift
left a comment
Member
There was a problem hiding this comment.
Yep, this fixes #750. 😀
Any chance of adding a comment for this line, explaining why it's set to "per Item" ?
justinclift
pushed a commit
that referenced
this pull request
Oct 8, 2016
Building the project with Qt5 on macOS and browsing a huge table, the scrollbar height was smaller than necessary. Scrolling to the end, some rows were not showing up. This was caused by the default vertical scroll mode, which is set to ScrollPerPixel on macOS, and ScrollPerItem on other systems. (cherry picked from commit e5bca9d)
vtronko
pushed a commit
that referenced
this pull request
Dec 29, 2016
Building the project with Qt5 on macOS and browsing a huge table, the scrollbar height was smaller than necessary. Scrolling to the end, some rows were not showing up. This was caused by the default vertical scroll mode, which is set to ScrollPerPixel on macOS, and ScrollPerItem on other systems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building the project with Qt5 on macOS and browsing a huge table, the
scrollbar height was smaller than necessary. Scrolling to the end, some
rows were not showing up.
This was caused by the default vertical scroll mode, which is set to
ScrollPerPixel on macOS, and ScrollPerItem on other systems.
Hope I was clear enough 😄
Related to #750.