Skip to content

Switch to using C++11 and Qt5 - #808

Merged
MKleusberg merged 4 commits into
masterfrom
c++11
Oct 18, 2016
Merged

MKleusberg merged 4 commits into
masterfrom
c++11

Conversation

@MKleusberg

Copy link
Copy Markdown
Member

See issue #603. Putting this here for further discussion and tests, but should be merged as soon as #750 and #775 are done.

@justinclift justinclift added the enhancement Feature requests. label Oct 8, 2016
@justinclift

Copy link
Copy Markdown
Member

Ahhh, that's weird. Travis was saying your "Use Qt5" commit was failing, but now it's ok.

@MKleusberg

Copy link
Copy Markdown
Member Author

@justinclift I was doing some tests with this branch and force pushing new versions to it, including multiple commits with the "Use Qt5" description. Might be because of that 😇

@justinclift

Copy link
Copy Markdown
Member

No worries at all. 😄

@justinclift

Copy link
Copy Markdown
Member

Issue #750 and #775 are both closed now.

We can probably merge this now. 😄

@MKleusberg

Copy link
Copy Markdown
Member Author

Awesome :D Has someone warned Rene though? After all this will break the build process for the 'old' nightlies. So the script he is running could be disabled and maybe a redirection from the old URL to the new could be set up instead.

@justinclift

justinclift commented Oct 17, 2016 •

Copy link
Copy Markdown
Member

Ahhh, good thinking. Emailed him a few minutes ago to let him know. 😄

@justinclift

Copy link
Copy Markdown
Member

Rene emailed this morning. The old MXE build script has been turned off, and he's put an automatic bounce in place from the old location to the new nightlies server.

I think we're good to get this done now. 😄

@MKleusberg

Copy link
Copy Markdown
Member Author

Ok, cool :) Let's give this a try then and see what happens.

@MKleusberg
MKleusberg merged commit 1ced897 into master Oct 18, 2016
@MKleusberg
MKleusberg deleted the c++11 branch October 18, 2016 15:31
@justinclift

Copy link
Copy Markdown
Member

Ironically, I'd forgotten to update the OSX nightly build script to use Qt5.

Now fixed. 😉

vtronko pushed a commit that referenced this pull request Dec 29, 2016
* grammar: Simplify code thanks to C++11 being there

* Use lambdas instead verbose slots for duplicating record

* travis: Use Qt5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Feature requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants