Repository navigation
Show selection statistics with full double precision - #4222
Open
deepsidhu1313 wants to merge 1 commit into
Open
deepsidhu1313 wants to merge 1 commit into
deepsidhu1313 wants to merge 1 commit into
Conversation
The Sum, Average, Min and Max values shown in the status bar of the Browse Data tab were formatted with QString::arg(double), which only uses 6 significant digits. Larger values were therefore rounded, e.g. 1234567.89 was shown as 1.23457e+06. Format them with 15 significant digits instead, which shows doubles accurately without exposing binary rounding noise. Fixes sqlitebrowser#4033
Member
|
I guess the real problem behind #4033 was using a floating-point type for an amount of money. That is always going to cause problems, even if we increase the precission. In any case, I suppose this won't cause any harm, unless we don't like to have so much precission for the average, even for integer data: 
What others think about this? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Sum, Average, Min and Max values shown in the status bar of the Browse
Data tab were formatted with QString::arg(double), which only uses 6
significant digits. Larger values were therefore rounded, e.g. 1234567.89
was shown as 1.23457e+06. Format them with 15 significant digits instead,
which shows doubles accurately without exposing binary rounding noise.
Fixes #4033