Repository navigation
Don't treat ASCII information separators as binary data - #4221
Open
deepsidhu1313 wants to merge 1 commit into
Open
deepsidhu1313 wants to merge 1 commit into
deepsidhu1313 wants to merge 1 commit into
Conversation
isTextOnly() treats every control character which Qt does not consider white space as a sign of binary data, so text containing the ASCII information separators CHAR(28) to CHAR(31) was displayed as a BLOB. These characters are regularly used as field and record delimiters in text, so exempt U+001C to U+001F from the check. The new test rows fail without this change. Fixes sqlitebrowser#4193
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isTextOnly() treats every control character which Qt does not consider
white space as a sign of binary data, so text containing the ASCII
information separators CHAR(28) to CHAR(31) was displayed as a BLOB. These
characters are regularly used as field and record delimiters in text, so
exempt U+001C to U+001F from the check.
The new test rows fail without this change.
Fixes #4193