Repository navigation
Don't add redundant xmlns attributes when formatting XML in the cell editor - #4220
Open
deepsidhu1313 wants to merge 1 commit into
Open
deepsidhu1313 wants to merge 1 commit into
deepsidhu1313 wants to merge 1 commit into
Conversation
…editor The XML in the cell editor was parsed with QDomDocument::setContent() and namespace processing enabled. With this, Qt repeats the default xmlns declaration on every descendant element when the document is serialised again, which bloated the XML whenever it was formatted or compacted. Turn namespace processing off so the namespace declarations are preserved as they are. Fixes sqlitebrowser#4189
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The XML in the cell editor was parsed with QDomDocument::setContent() and
namespace processing enabled. With this, Qt repeats the default xmlns
declaration on every descendant element when the document is serialised
again, which bloated the XML whenever it was formatted or compacted. Turn
namespace processing off so the namespace declarations are preserved as
they are.
Fixes #4189