Repository navigation
Fix CSV import detecting columns of decimal numbers as INTEGER - #4218
Open
deepsidhu1313 wants to merge 1 commit into
Open
deepsidhu1313 wants to merge 1 commit into
deepsidhu1313 wants to merge 1 commit into
Conversation
In ImportCsvDialog::generateFieldList, a column which had already been detected as REAL was reset to INTEGER when the next value was also numeric, so the detected type flipped back and forth from row to row. For example a column with the values 0.3 and 0.06 ended up as INTEGER. Keep the type REAL as long as the values are still convertible to a floating point number. Fixes sqlitebrowser#4035
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ImportCsvDialog::generateFieldList, a column which had already been
detected as REAL was reset to INTEGER when the next value was also numeric,
so the detected type flipped back and forth from row to row. For example a
column with the values 0.3 and 0.06 ended up as INTEGER. Keep the type
REAL as long as the values are still convertible to a floating point
number.
Fixes #4035