Repository navigation
Fix infinite loop when adding a column to an existing primary key - #4217
Open
deepsidhu1313 wants to merge 1 commit into
Open
deepsidhu1313 wants to merge 1 commit into
deepsidhu1313 wants to merge 1 commit into
Conversation
Table::addKeyToConstraint() inserts the extended constraint into the multimap while iterating over it. The column list [a,b] sorts after [a], so the loop finds the same constraint again and extends it forever, which froze the application and ended in a bad_alloc when ticking a second primary key checkbox in the Edit Table dialog. removeKeyFromConstraint() has the same pattern. A constraint object is only stored once, so stop after updating it. A new unit test covers adding and removing keys; it hangs without this fix. Fixes sqlitebrowser#4150
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Table::addKeyToConstraint() inserts the extended constraint into the
multimap while iterating over it. The column list [a,b] sorts after [a], so
the loop finds the same constraint again and extends it forever, which
froze the application and ended in a bad_alloc when ticking a second
primary key checkbox in the Edit Table dialog. removeKeyFromConstraint()
has the same pattern. A constraint object is only stored once, so stop
after updating it.
A new unit test covers adding and removing keys; it hangs without this
fix.
Fixes #4150