Skip to content

Fixes crash in v3.12.2 when opening the "Modify Table" dialog - #3075

Merged
justinclift merged 1 commit into
v3.12.xfrom
v3.12.x-fix-crash
Jun 24, 2022
Merged

justinclift merged 1 commit into
v3.12.xfrom
v3.12.x-fix-crash

Conversation

@mgrojo

@mgrojo mgrojo commented Jun 22, 2022

Copy link
Copy Markdown
Member

See issues #2779 and #3069.

@mgrojo

mgrojo commented Jun 22, 2022

Copy link
Copy Markdown
Member Author

In master was already fixed in b076211

I don't know if we want to do a bug fix release, so I've opened this PR for the v3.12.x branch.

@justinclift

Copy link
Copy Markdown
Member

My C++/Qt skills aren't good enough to review this any more, but the idea of doing this in the 3.12.x branch is a good one. 😄

@mgrojo

mgrojo commented Jun 24, 2022 •

Copy link
Copy Markdown
Member Author

My C++/Qt skills aren't good enough to review this any more, but the idea of doing this in the 3.12.x branch is a good one. smile

There's no need of review for the code, because the same change was applied by @MKleusberg in the master branch. The reason behind the pull request is that I didn't want to modify a release branch without someone else agreeing. It makes sense if we are going to make a fix release for this branch, but we might prefer to go directly for the long delayed 3.13 release.

@justinclift
justinclift merged commit 42476ac into v3.12.x Jun 24, 2022
@justinclift
justinclift deleted the v3.12.x-fix-crash branch June 24, 2022 19:45
@justinclift

Copy link
Copy Markdown
Member

Makes sense. Just merged this, so it's in the branch for whoever builds from this branch anyway. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants