Skip to content

Show current database action in status bar and add cancel button - #1563

Merged
MKleusberg merged 1 commit into
masterfrom
interrupt_query
Nov 8, 2018
Merged

MKleusberg merged 1 commit into
masterfrom
interrupt_query

Conversation

@MKleusberg

Copy link
Copy Markdown
Member

Same as for my other PR:

  1. Any obvious issues here? I'm especially interested how the status bar button looks on other platforms.
  2. Do you consider this safe enough to be cherry-picked to the 3.11 branch?

Interrupting running queries in the Execute SQL tab will be added later because it requires some major rewriting.

Original commit message
This adds a label to the status bar which becomes visible whenever the
database is busy. It also specifies the currently running action. Also
add a button which allows you to cancel this action at the next
opportunity.

Note that this doesn't work for the Execute SQL tab yet which requires
some more rewriting of the code there.

This adds a label to the status bar which becomes visible whenever the
database is busy. It also specifies the currently running action. Also
add a button which allows you to cancel this action at the next
opportunity.

Note that this doesn't work for the Execute SQL tab yet which requires
some more rewriting of the code there.
@mgrojo

mgrojo commented Oct 11, 2018

Copy link
Copy Markdown
Member

Awesome! This is how it looks:

imagen

@MKleusberg

Copy link
Copy Markdown
Member Author

Merging this since it's a relatively safe change and I haven't heard about any problems. But I won't cherry-pick it over to the 3.11 branch since it adds to little to warrant the hassle 😉

@MKleusberg
MKleusberg merged commit 11ace1e into master Nov 8, 2018
@MKleusberg
MKleusberg deleted the interrupt_query branch November 8, 2018 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants