Skip to content

Add Windows XP support - #1011

Merged
justinclift merged 1 commit into
sqlitebrowser:masterfrom
karim:master
May 12, 2017
Merged

justinclift merged 1 commit into
sqlitebrowser:masterfrom
karim:master

Conversation

@karim

@karim karim commented May 12, 2017

Copy link
Copy Markdown
Member

Change the default subsystem used by MSVC linker to allow DB4S to run on Windows XP (32-bit and 64-bit).

See issues #893, #986, and #1010.

@justinclift

Copy link
Copy Markdown
Member

Looks good to me. We should probably get someone with an actual XP box to verify it first, just to be on the safe side.

@justinclift

Copy link
Copy Markdown
Member

Aha, found one of my old MSDN XP ISO's. No idea if it'll work, but I'll try running it up on a box here and see what happens. 😄

@karim

karim commented May 12, 2017

Copy link
Copy Markdown
Member Author

Good luck. 😄

@justinclift

justinclift commented May 12, 2017 •

Copy link
Copy Markdown
Member

Got stuck on the Product Key bit. I have one (a sticker on real hardware locally), but don't want to blow it on just a temporary test thing.

The comment by @h1618 makes this PR look good though, so I'll merge this now. We'll just need to make sure our nightly builds for XP are on a system with Qt 5.6.x (maximum) on it.

Thanks for this @karim, and welcome to the team. 😄

@karim

karim commented May 12, 2017

Copy link
Copy Markdown
Member Author

Thanks. 😄

Yes, Qt 5.6 should work... at least until March 2019.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants