Repository navigation
Warnings during compile #8
Description
Not build breakers, but if these are easy to fix we might as well:
clang++ -c -pipe -O2 -arch x86_64 -fPIC -Wall -W -DQT_NO_DEBUG -DQT_GUI_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/local/Cellar/qt/4.8.6/mkspecs/unsupported/macx-clang -I. -I/usr/local/Cellar/qt/4.8.6/lib/QtCore.framework/Versions/4/Headers -I/usr/local/Cellar/qt/4.8.6/lib/QtCore.framework/Versions/4/Headers -I/usr/local/Cellar/qt/4.8.6/lib/QtGui.framework/Versions/4/Headers -I/usr/local/Cellar/qt/4.8.6/lib/QtGui.framework/Versions/4/Headers -I/usr/local/Cellar/qt/4.8.6/include -I. -Irelease -F/usr/local/Cellar/qt/4.8.6/lib -o release/RecognitionException.o src/RecognitionException.cpp
src/String.cpp:41:19: warning: format specifies type 'unsigned int' but the argument has type 'size_t'
(aka 'unsigned long') [-Wformat]
sprintf(tmp,"%u",rhs);
~~ ^~~
%lu
1 warning generated.
clang++ -c -pipe -O2 -arch x86_64 -fPIC -Wall -W -DQT_NO_DEBUG -DQT_GUI_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/local/Cellar/qt/4.8.6/mkspecs/unsupported/macx-clang -I. -I/usr/local/Cellar/qt/4.8.6/lib/QtCore.framework/Versions/4/Headers -I/usr/local/Cellar/qt/4.8.6/lib/QtCore.framework/Versions/4/Headers -I/usr/local/Cellar/qt/4.8.6/lib/QtGui.framework/Versions/4/Headers -I/usr/local/Cellar/qt/4.8.6/lib/QtGui.framework/Versions/4/Headers -I/usr/local/Cellar/qt/4.8.6/include -I. -Irelease -F/usr/local/Cellar/qt/4.8.6/lib -o release/CommonASTWithHiddenTokens.o src/CommonASTWithHiddenTokens.cpp
In file included from src/CommonASTWithHiddenTokens.cpp:9:
./antlr/BaseAST.hpp:140:61: warning: unused parameter 'txt' [-Wunused-parameter]
virtual void setText(const ANTLR_USE_NAMESPACE(std)string& txt)
^
./antlr/BaseAST.hpp:145:27: warning: unused parameter 'type' [-Wunused-parameter]
virtual void setType(int type)
^
2 warnings generated.
Activity
MKleusberg commentedon May 14, 2014
To be honest, I would leave these warnings and not try to fix them. The reason is that this is code not written by us (in this case the antlr library which is iinked statically into the application) and if we decide at some point to update this library to the latest version all our changes are lost anyway.
Just my opinion, but they should be fixed upstream - especially the first one.
justinclift commentedon May 14, 2014
No worries. Lets close this then. 😃
rp- commentedon May 15, 2014
Usually i would fully agree with Martin, but as we use a very old version
of antlr which will not see a new upstream release. we can fix those
warnings.
On May 15, 2014 1:37 AM, "Justin Clift" notifications@github.com wrote: