Repository navigation
New location of the "x" to close a tab is awkward? #2155
Description
I searched for the ticket where this change would have been made, but couldn't find it. Please redirect if I'm positing in the wrong place.
I was running a nightly build recently and noticed the "x" to close a query tab has been moved from being on the tab to being alone on the right hand side. I am curious why this was done? In my opinion, the new location is not intuitive (makes it look like I am closing all tabs) and is not consistent with other programs that use tabs (web browsers, etc).
Current DB4S (Version 3.11.2):
Nightly DB4S:
...
Activity
sky5walk commentedon Mar 4, 2020
Read Issue #1968
You can delete individual tabs with right mouse menu click.
A gui problem still appears for users of many Execute SQL tabs.
New setting for having close button on tabs (default) or not
mgrojo commentedon Jun 2, 2020
@beRto- The next nightly build will have a preference setting for having close buttons on tabs as in 3.11 and before, or not. The corner button has been removed, since we have the contextual menu and the shortcut (Ctrl+W). Please confirm it works as expected, since we have to include this in the final 3.12 version.
sky5walk commentedon Jun 3, 2020
Nightly v200603 works great! No more unsightly scrunched [x] buttons. 💯
beRto- commentedon Jun 3, 2020
@mgrojo - nice! I just had a chance to test this using Version 3.12.99 (Jun 3 2020). I confirm each tab now has the "x" restored, as expected. Unfortunately, I was not able to test the preference setting to remove the close buttons. I expected to see some kinds of "Show close button on each tab" checkbox on under Preferences >> General, but did not find it there (or anywhere else). Could you please point me to it?
mgrojo commentedon Jun 3, 2020
beRto- commentedon Jun 3, 2020
@mgrojo OK, I see it now, thanks!
I would naively have expected it under General because it's not really an SQL preference, but just a display/interface preference?
That said, I can see a valid argument that these "x" only show up in tabs under Execute SQL. And so I would also agree the setting makes sense where it is right now.
In short, I like this change and thank you for looking into it! :)
mgrojo commentedon Jun 3, 2020
Thanks for the feedback!
New setting for having close button on tabs (default) or not