Repository navigation
Drop close buttons on every Execute SQL tab(x).聽#1968
Description
Describe the new feature
Now that we have localized context menu items: close,duplicate,rename; 馃構
It really makes sense to remove(or make optional) the SQL1(x) close button on every tab.
It is soooo easy to hit that by mistake with high res screens. And when I have more than 10 tabs, the left-right scroll buttons become obscured and overlay with the close (x).
Additional info
This is also a bug report given the scrunched scrollbar buttons with many SQL tabs.
Is your feature request related to an issue? Please include the issue number.
No.
Does this feature exist in another product or project? Please provide a link.
Yes, Notepad++ and other multi-tab environments allow disabling close buttons.
Do you have a screenshot? Please add screenshots to help explain your idea.
Activity
justinclift commentedon Aug 17, 2019
Sounds reasonable. 馃槃
MKleusberg commentedon Aug 18, 2019
Quick poll: Should we add a checkbox to the Settings dialog for this, and if so, what should be the default? Or should we remove the close buttons and add a single button for closing the current tab (that's what I'm leaning towards)? Or should we just remove the close buttons altogether?
mgrojo commentedon Aug 18, 2019
I like close buttons in the tabs. It's better when you have to close a lot of open tabs. So I'd prefer a setting and default to current behaviour. A single button for closing the current tab is a good idea for the other option of the setting. The main tabs should probably follow this setting too.
mgrojo commentedon Aug 18, 2019
That seems a problem with the style https://github.com/ColinDuquesnoy/QDarkStyleSheet I'll try updating it and if it still happens, we should report it there.
sky5walk commentedon Aug 18, 2019
Thanks!
My preference and philosophy is always more editable real estate.
Meaning, less manual scrolling and less distracting images for the 90% work mode.
(Maybe 10% or less of the time is spent browsing menus after a user becomes proficient in any app.)
Eliminating crowded close buttons reduces mouse accuracy required while navigating the gui.
As the number of SQL tabs increase, the potential to mis-click a close button increases and forces the user to stop and think about minutiae. The context menu is a big improvement as it is near impossible to enter by mistake.
sky5walk commentedon Aug 19, 2019
Ok, latest nightly appears better but there are still overlapping buttons. Except now there is a visible highlight box around the left or right horizontal scrollbar. Much easier to tell what to click.
Possible fixes:
-Shrink the tab width for any tab right of the scrollbar.
-Move the scrollbar permanently to the leftmost position of the list. It will never overlap.
-Do not show any tabs >= scrollbar position.
mglatz commentedon Sep 24, 2019
I also vote for setting. I too have accidentally closed tab I really wished to keep
sky5walk commentedon Nov 19, 2019
Wow, I forgot to mention, due to tab crowding, I cannot reliably scroll left and right. 馃槰
Can we please drop the Close buttons for a trial run? It is a mess.
This is what the nightlies prove out.
Remove close buttons on tabs and add button for closing SQL tabs
MKleusberg commentedon Nov 20, 2019
Yep, let's try it 馃槃 Can you try the next nightly build? It drops the close buttons for the main tabs and the Execute SQL tabs, and adds a close tab button to the Execute SQL tab bar.
sky5walk commentedon Nov 21, 2019
Whoa 馃寽 Almost there.
The clutter is gone, but the added close tab on the end [<][>][X] causes the same inadvertent loss of a SQL tab. Please drop the close button altogether. We have [right mouse click] menu and [Ctrl+W]. I can barely see the navigate left arrow due to the close button dominating the real estate.
justinclift commentedon Nov 24, 2019
As long as it's an option. Personally, I use those close buttons. 馃槃
sky5walk commentedon Nov 24, 2019
Yes, an option is fine. Projects with < 5 or so SQL tabs will not see this problem. With more SQL tabs and long names, the scrunch is scary.
karim commentedon Nov 30, 2019
I think removing the close button is fine and could be the default option. Tabs can be closed using the mouse middle button.
We should also add a toggle to show it since some users (who don't open a lot of tabs) might prefer it. I see this pattern in a lot of apps.
28 remaining items
beRto- commentedon May 6, 2020
For what it's worth, I agree the single button waaay over there is hidden and confusing. I would also vote for the simple Notepad++ style on/off option (show on all tabs, or show on none).
justinclift commentedon May 6, 2020
Yeah, at least at the moment, I personally prefer having the close buttons on all the tabs. So as long as that's one of the options, I'm happy. 馃槃
mgrojo commentedon May 6, 2020
@MKleusberg, have you missed my comment #1968 (comment) ? To me, it passes my threshold of maintenance level, but that's very subjective. Besides, I prefer it to the corner close button, which is unusual GUI style.
The only drawback with that solution is that we don't take back the space used by the close button, since it is only hidden. I'd go for the three options mentioned in #1968 (comment). But two options (none, all) is also fine for me.
New setting for having close button on tabs (default) or not
mgrojo commentedon Jun 2, 2020
The next nightly build will have a preference setting for having close buttons on tabs as in 3.11 and before, or not. The corner button has been removed, since we have the contextual menu and the shortcut (Ctrl+W). Please confirm it works as expected, since we have to include this in the final 3.12 version.
sky5walk commentedon Jun 3, 2020
Nightly v200603 works great! No more unsightly scrunched [x] buttons. 馃挴
New setting for having close button on tabs (default) or not
[-][Feature Request] Drop close buttons on every Execute SQL tab(x).[/-][+]Drop close buttons on every Execute SQL tab(x).[/+]