Repository navigation
Deleting a Field Occurs Despite Clicking Cancel #1116
Description
Details for the issue
Wasn't sure if this was a bug (seems a bit dangerous if so!) or 'by design'.
Removing a field via 'Modify Database' and clicking Cancel performs the deletion anyway, with no 'Write Changes' or 'Revert Changes' being available.
Found this while testing for #1115 .
https://screencast-o-matic.com/watch/cbQVq3Iflu
The screencast deletes an index first, as I thought it was related, but its a red herring. I created a new table, saved changes, then deleted a field with no 'Write Changes' button.
Skip to 20 seconds in to ignore the index deleting bit.
Useful extra information
I'm opening this issue because:
- DB4S is crashing
- DB4S has a bug
- DB4S needs a feature
- DB4S has another problem
I'm using DB4S on:
- Windows: ( version: 10___ )
- Linux: ( distro: ___ )
- Mac OS: ( version: ___ )
- Other: ___
I'm using DB4S version:
- 3.10.99
- 3.10.0-beta*
- 3.9.1
- Other: ___
I have also:
- Tried out the latest nightly version: https://github.com/sqlitebrowser/sqlitebrowser#nightly-builds
- Searched for an existing similar issue: https://github.com/sqlitebrowser/sqlitebrowser/issues?utf8=%E2%9C%93&q=is%3Aissue%20
Activity
[-]Deleting a Field Is Permanent Despite Clicking Cancel[/-][+]Deleting a Field Occurs Despite Clicking Cancel[/+]justinclift commentedon Sep 1, 2017
Ouch. Yep, that's a bug. Definitely the kind of thing which could catch people out. 😨
Don't automatically commit all changes when editing a table column
MKleusberg commentedon Sep 2, 2017
It should be fixed now. But maybe you can double check, especially to see if there are any other corner cases left? 😄 By the way, the index deleting bit was actually important. With an unmodified database it works as expected. But still, we might want to include this in a 3.10.1 release or so 😉 (together with #1115 etc).
justinclift commentedon Sep 2, 2017
Yeah, a 3.10.1 in a week or so would probably make sense. 😄
Don't automatically commit all changes when editing a table column
justinclift commentedon Sep 18, 2017
@chrisjlocke Do you have time to verify this issue is fixed for you? 😄
chrisjlocke commentedon Sep 18, 2017
Sorry - yes, this now appears fixed. Can't seem to break it! 🍭
justinclift commentedon Sep 18, 2017
Thanks @chrisjlocke. 😄