Repository navigation
[Suggestion] Progress for downloading/uploading #1095
Description
Details for the issue
I'm not sure whats possible, so just throwing this out as a suggestion.
Would it be possible to show how many KB/MB have been down/uploaded so far, to give some sort of progress on where the download/upload is?
Currently, the dialog gives no indication.
I know with my own tinkerings with network traffic, its not always possible to get that info.
Edit: Oh, I see the upload already does that...
Useful extra information
I'm opening this issue because:
- DB4S is crashing
- DB4S has a bug
- DB4S needs a feature
- DB4S has another problem
I'm using DB4S on:
- Windows: ( version: ___ )
- Linux: ( distro: ___ )
- Mac OS: ( version: ___ )
- Other: ___
I'm using DB4S version:
- 3.10.0
- 3.10.0-beta*
- 3.9.1
- Other: ___
I have also:
- Tried out the latest nightly version: https://github.com/sqlitebrowser/sqlitebrowser#nightly-builds
- Searched for an existing similar issue: https://github.com/sqlitebrowser/sqlitebrowser/issues?utf8=%E2%9C%93&q=is%3Aissue%20
Activity
justinclift commentedon Aug 21, 2017
Yep, it definitely should be possible. Interestingly, the code for displaying the progress dialog is the same for both upload and download.
I think the problem is that the server isn't sending the filesize to DB4S when the download kicks off, so DB4S doesn't know where the end is until it hits it.
Kind of thinking I should be able to get that fixed today, in which case the download progress bar (hopefully) should just start working. 😄
justinclift commentedon Aug 21, 2017
Yep, it was a simple fix. sqlitebrowser/dbhub.io@6abd350
The download just needed a
Content-Lengthheader sent at the start. Download progress bars are working (both Firefox and DB4S) now. Well, at least when testing just now anyway. 😉justinclift commentedon Aug 25, 2017
@chrisjlocke Reminder ping. Hoping you have a chance to verify this. 😄
chrisjlocke commentedon Aug 25, 2017
I'll try again. 👍
justinclift commentedon Sep 1, 2017
@chrisjlocke Reminder ping. 😄
chrisjlocke commentedon Sep 1, 2017
Aah yes, I was looking at this the other day when I came across the 'multiple download' issue, so forgot to update this one.
Both are working well, so I can close this.
The pedant in me wants to remove the closing "." from the end of the filename though... 😉
dbhub: Remove closing "." from the progress dialog
MKleusberg commentedon Sep 1, 2017
Just removed the closing "." from the upload and download dialog 😉
justinclift commentedon Sep 1, 2017
Oh, related to this, the upload progress bar doesn't show correctly with larger size files. Instead the whole dialog just flickers. The upload itself works though.
@MKleusberg If you're wanting to take a look, you don't need to upload the whole file. It does the flickering thing right from the start. Oh, I'll need to update the server so it doesn't apply the upload limits to you. Will get that done in a sec anyway. 😄
justinclift commentedon Sep 1, 2017
k, upload limits via DB4S shouldn't affect yourselves now. It's done via dodgy hot patch though, instead of anything proper... so might need to be reapplied again later until something better is put in place. eg "Admin accounts" or similar as @chrisjlocke suggested the other day
justinclift commentedon Sep 1, 2017
@MKleusberg Ahhh... "mtest3". I whitelisted the wrong username. 1 min. 😄
MKleusberg commentedon Sep 1, 2017
No problem 😄
justinclift commentedon Sep 1, 2017
k, should be good now. 😄
2 remaining items
justinclift commentedon Sep 1, 2017
I haven't looked further to figure out where the threshold for mucking up is.
MKleusberg commentedon Sep 1, 2017
Ok, give me some time for this. I'm downloading the 2.9GB file now 😉
justinclift commentedon Sep 1, 2017
Maybe generate your own? 😄
https://github.com/sqlitebrowser/sqlitedatagen
You'd need Go installed, but the generation itself is reasonably quick. ~5 seconds per 80MB on this old Linux desktop.
MKleusberg commentedon Sep 1, 2017
Yeah thought about that too but figured that it's faster to just download your file because it's just one click and I can do other stuff while it's loading 😉
chrisjlocke commentedon Sep 1, 2017
"Its OK - just Martin downloading those large test files again..."
justinclift commentedon Sep 1, 2017
Heh Heh Heh 😄
Yeah, measurements/monitoring hasn't yet been done on the server while larger sized files are downloaded by DB4S. Uploads were pretty relaxed (3% of one cpu) during the 2.9GB upload, mostly due to buffer management I'm guessing. Seems ok for now, so not a priority to look at optimising (yet). 😉
MKleusberg commentedon Sep 1, 2017
I don't get any flickering even with the 2.9GB file. But the progress bar isn't working properly either. I assume it's because the progress dialog takes
intvalues and if those are 32bit wide it will overflow for file sizes greater than 2^32/2 Byte, i.e. 2GB. I'll push a fix for that in a second 😄dbhub: Fix progress dialog for very large files
MKleusberg commentedon Sep 1, 2017
Ok can you test again with the latest commit applied? In theory the progress dialog should work fine now 😉
justinclift commentedon Sep 1, 2017
Sure, gimme 5. 😄
justinclift commentedon Sep 1, 2017
Yep, this is working smoothly now too. Nicely shown, no flickering, smooth updates. Awesome @MKleusberg!
MKleusberg commentedon Sep 1, 2017
Awesome 😄 Thanks for testing!
dbhub: Remove closing "." from the progress dialog
dbhub: Fix progress dialog for very large files