Repository navigation
Refuse sqlite3_rekey_v2 while a transaction is open - #627
Open
LucaCappelletti94 wants to merge 1 commit into
Open
LucaCappelletti94 wants to merge 1 commit into
LucaCappelletti94 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 5.0.0-beta,
sqlite3_rekey_v2commits its btree transaction even when the connection already holds one, so it ends a transaction it never owned. InsideBEGINorSAVEPOINT, a laterROLLBACKthen restores nothing. From a callback of a runningINSERT, it commits the partial writes, and anINSERTthat then fails stays half applied. Alongside aSELECTstill stepping, it drops the read lock under the open cursor, which trips an assertion inSQLITE_DEBUGbuilds.As
PRAGMA cipher_migratealready does,sqlite3_rekey_v2now returnsSQLITE_MISUSEwhen autocommit is off or the target btree holds any transaction. The check runs before anything is touched and returns directly, since the cleanup path would roll back the caller's transaction.The tests cover
BEGIN,SAVEPOINT, an attached schema, a runningINSERTand a runningSELECT.