Make timestampdiff return int.#915
Merged
Merged
Conversation
So the mysql timestampdiff documentation does not explicitly declare the return type, but the documentation heavily implies int. On the other hand, the MariaDB documentation explicitly specifies it as int, so we're going to run with int.
victoraugustolls
pushed a commit
to Streppel/sqlc
that referenced
this pull request
May 6, 2021
So the mysql timestampdiff documentation does not explicitly declare the return type, but the documentation heavily implies int. On the other hand, the MariaDB documentation explicitly specifies it as int, so we're going to run with int. Co-authored-by: Zephaniah E. Loss-Cutler-Hull <warp@aehallh.com> Co-authored-by: Kyle Conroy <kyle@conroy.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So the mysql timestampdiff documentation does not explicitly declare the
return type, but the documentation heavily implies int.
On the other hand, the MariaDB documentation explicitly specifies it as
int, so we're going to run with int.