Open
Conversation
* origin/main: (91 commits) build(deps): bump urllib3 from 2.6.2 to 2.6.3 in /docs (sqlc-dev#4259) build(deps): bump golang from 1.26.0 to 1.26.1 (sqlc-dev#4328) build(deps): bump the production-dependencies group across 1 directory with 4 updates (sqlc-dev#4348) Upgrade Go version to 1.26.0 (sqlc-dev#4312) Install PostgreSQL from theseus-rs/postgresql-binaries instead of apt (sqlc-dev#4310) build(deps): bump golang from 1.25.5 to 1.26.0 (sqlc-dev#4294) build(deps): bump the production-dependencies group across 1 directory with 2 updates (sqlc-dev#4296) Add sqlc-test-setup command for database test environment setup (sqlc-dev#4304) build(deps): bump filippo.io/edwards25519 from 1.1.0 to 1.1.1 (sqlc-dev#4303) build(deps): bump the production-dependencies group across 1 directory with 4 updates (sqlc-dev#4284) feat: add ClickHouse support to `sqlc parse` (sqlc-dev#4267) Add GitHub Topic to the plugins page (sqlc-dev#4258) build(deps): bump the production-dependencies group across 1 directory with 2 updates (sqlc-dev#4256) build(deps): bump the production-dependencies group across 1 directory with 4 updates (sqlc-dev#4248) fix(native): make MySQL connection check immediate on first attempt (sqlc-dev#4254) feat: graduate parsecmd experiment (sqlc-dev#4253) docs: Add Claude Code remote environment setup instructions (sqlc-dev#4246) Add parse subcommand with AST JSON output (sqlc-dev#4240) feat(postgresql): add analyzerv2 experiment for database-only analysis (sqlc-dev#4237) feat: add native database support for e2e tests without Docker (sqlc-dev#4236) ... # Conflicts: # internal/engine/sqlite/convert.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up on #3962
initial PR desciprtion:
sqlc currently doesn't handle bound ORDER BY clauses in sqlite, nor does it have tests for this behavior. This PR attempts for rectify this. Closes #3788.
Brings things back in the main
convertOrderby_stmtContextand fixes the initial issue that didn't properly output?2, ?11, ...@andriygm I tried to make this PR against your repo / branch so you could update your own PR isntead of me making the PR since this is mostly your work, but couldn't figure out the Github UI. Your repo never seemed to appear in the list.