Skip to content

fix(#4332, #4336): type checking when the same parameter is repeated #4335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qykr wants to merge 11 commits into
base: main
Choose a base branch
from
Open

fix(#4332, #4336): type checking when the same parameter is repeated #4335

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
bd77a02
fix: fixed issue 4332, now type checks for consistency when the same …
qykr Mar 10, 2026
f758c7e
fix: human readable formatting for types
qykr Mar 10, 2026
f6af815
fix: some type bugs
qykr Mar 10, 2026
c6a0a6a
fix: type bugs
qykr Mar 10, 2026
931dc7f
fix: find_params bug
qykr Mar 10, 2026
4112a36
fix: managed-db issues
qykr Mar 10, 2026
e147043
fix: pgx not detecting
qykr Mar 11, 2026
8a3f88f
fix: broken e2e test
qykr Mar 11, 2026
9fd3fac
fix: invalid_used_param_type managed-db and base separation
qykr Mar 11, 2026
e91d62c
fix: nested_select e2e
qykr Mar 11, 2026
ae0a126
fix: all e2e tests fixed
qykr Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: broken e2e test
  • Loading branch information
@qykr
qykr committed Mar 11, 2026
commit 8a3f88f08e6511100b6f9993f618bc31ea97e7c3
1 change: 0 additions & 1 deletion internal/compiler/analyze.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ func combineAnalysis(prev *analysis, a *analyzer.Analysis) *analysis {
// (not "any"), since the catalog-based inference may have better info
if params[i].Column.DataType != "any" {
prev.Parameters[i].Column.DataType = params[i].Column.DataType
prev.Parameters[i].Column.NotNull = params[i].Column.NotNull
prev.Parameters[i].Column.IsArray = params[i].Column.IsArray
prev.Parameters[i].Column.ArrayDims = params[i].Column.ArrayDims
}
Expand Down
6 changes: 2 additions & 4 deletions internal/endtoend/testdata/insert_select_param/postgresql/pgx/go/query.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading