Skip to content

fix(sqlite): disable positional indexing when sqlc.slice is present #4330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noxymon wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(sqlite): disable positional indexing when sqlc.slice is present #4330

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eec37da
feat(sqlite): disable positional indexing when sqlc.slice is present
Mar 7, 2026
953e0e3
test(sqlite): add repro and reuse cases for sqlc.slice positional ind…
Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat(sqlite): disable positional indexing when sqlc.slice is present
  • Loading branch information
Pickle Rick committed Mar 7, 2026
commit eec37da61cc2476448dcd56232f740d43f6c5a77
31 changes: 31 additions & 0 deletions internal/endtoend/testdata/issue_4213_reuse/sqlite/go/db.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions internal/endtoend/testdata/issue_4213_reuse/sqlite/go/models.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

58 changes: 58 additions & 0 deletions internal/endtoend/testdata/issue_4213_reuse/sqlite/go/query.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions internal/endtoend/testdata/issue_4213_reuse/sqlite/query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
-- name: ReuseWithSlice :many
SELECT * FROM mytable
WHERE typ IN (sqlc.slice(types)) AND (name = @name OR id = @id OR name = @name);
5 changes: 5 additions & 0 deletions internal/endtoend/testdata/issue_4213_reuse/sqlite/schema.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
CREATE TABLE mytable (
id INTEGER PRIMARY KEY,
typ INTEGER NOT NULL,
name TEXT NOT NULL
);
16 changes: 16 additions & 0 deletions internal/endtoend/testdata/issue_4213_reuse/sqlite/sqlc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"version": "2",
"sql": [
{
"engine": "sqlite",
"queries": "query.sql",
"schema": "schema.sql",
"gen": {
"go": {
"package": "querytest",
"out": "go"
}
}
}
]
}
6 changes: 3 additions & 3 deletions internal/endtoend/testdata/sqlc_slice/sqlite/go/query.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion internal/endtoend/testdata/sqlc_slice_prepared/sqlite/go/query.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 24 additions & 3 deletions internal/sql/rewrite/parameters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,20 @@ func paramFromFuncCall(call *ast.FuncCall) (named.Param, string) {
func NamedParameters(engine config.Engine, raw *ast.RawStmt, numbs map[int]bool, dollar bool) (*ast.RawStmt, *named.ParamSet, []source.Edit) {
foundFunc := astutils.Search(raw, named.IsParamFunc)
foundSign := astutils.Search(raw, named.IsParamSign)

hasSlice := false
for _, item := range foundFunc.Items {
if call, ok := item.(*ast.FuncCall); ok && call.Func.Name == "slice" {
hasSlice = true
break
}
}

hasNamedParameterSupport := engine != config.EngineMySQL
if engine == config.EngineSQLite && hasSlice {
hasNamedParameterSupport = false
}

allParams := named.NewParamSet(numbs, hasNamedParameterSupport)

if len(foundFunc.Items)+len(foundSign.Items) == 0 {
Expand All @@ -108,7 +121,7 @@ func NamedParameters(engine config.Engine, raw *ast.RawStmt, numbs map[int]bool,
// since it's needed during template generation for replacement
replace = fmt.Sprintf(`/*SLICE:%s*/?`, param.Name())
} else {
if engine == config.EngineSQLite {
if engine == config.EngineSQLite && hasNamedParameterSupport {
replace = fmt.Sprintf("?%d", argn)
} else {
replace = "?"
Expand Down Expand Up @@ -143,7 +156,11 @@ func NamedParameters(engine config.Engine, raw *ast.RawStmt, numbs map[int]bool,
if engine == config.EngineMySQL || !dollar {
replace = "?"
} else if engine == config.EngineSQLite {
replace = fmt.Sprintf("?%d", argn)
if hasNamedParameterSupport {
replace = fmt.Sprintf("?%d", argn)
} else {
replace = "?"
}
} else {
replace = fmt.Sprintf("$%d", argn)
}
Expand Down Expand Up @@ -171,7 +188,11 @@ func NamedParameters(engine config.Engine, raw *ast.RawStmt, numbs map[int]bool,
if engine == config.EngineMySQL || !dollar {
replace = "?"
} else if engine == config.EngineSQLite {
replace = fmt.Sprintf("?%d", argn)
if hasNamedParameterSupport {
replace = fmt.Sprintf("?%d", argn)
} else {
replace = "?"
}
} else {
replace = fmt.Sprintf("$%d", argn)
}
Expand Down