Skip to content

feat: add native database support for e2e tests without Docker #4236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleconroy merged 9 commits into from
Dec 18, 2025
Merged

feat: add native database support for e2e tests without Docker #4236

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
693c335
feat: add native database support for e2e tests without Docker
claude Dec 18, 2025
1a2126d
fix: fail tests instead of skipping when database unavailable
claude Dec 18, 2025
e0cd02f
fix: only enable managed-db context when databases are available
claude Dec 18, 2025
a354b38
fix: restore skip behavior in local database helpers
claude Dec 18, 2025
7f2af48
fix: add timeout to MySQL apt-get installation
claude Dec 18, 2025
43aa8f9
fix: use Linux timeout command for apt-get installation
claude Dec 18, 2025
2b4e740
refactor: remove apt-get installation from native database support
claude Dec 18, 2025
4d81c76
chore: remove GitHub Actions references from comments
claude Dec 18, 2025
ebe4489
chore: remove GitHub Actions section from CLAUDE.md
claude Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: use Linux timeout command for apt-get installation 
Use the Linux timeout command instead of context timeout for apt-get
since exec.CommandContext doesn't properly kill child processes when
using sudo. This ensures apt-get is properly terminated after 60 seconds.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
  • Loading branch information
@claude
claude committed Dec 18, 2025
commit 43aa8f96dc63bfb7c4f9ec5120784729cee117ce
13 changes: 5 additions & 8 deletions internal/sqltest/native/mysql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,21 +96,18 @@ func startMySQLServer(ctx context.Context) (string, error) {
if _, err := exec.LookPath("mysql"); err != nil {
slog.Info("native/mysql", "status", "installing")

// Pre-configure MySQL root password (with timeout)
debconfCtx, debconfCancel := context.WithTimeout(ctx, 10*time.Second)
defer debconfCancel()
setSelectionsCmd := exec.CommandContext(debconfCtx, "sudo", "bash", "-c",
// Pre-configure MySQL root password (with timeout using Linux timeout command)
setSelectionsCmd := exec.Command("sudo", "timeout", "10",
"bash", "-c",
`echo "mysql-server mysql-server/root_password password mysecretpassword" | sudo debconf-set-selections && `+
`echo "mysql-server mysql-server/root_password_again password mysecretpassword" | sudo debconf-set-selections`)
setSelectionsCmd.Env = append(os.Environ(), "DEBIAN_FRONTEND=noninteractive")
if output, err := setSelectionsCmd.CombinedOutput(); err != nil {
slog.Debug("native/mysql", "debconf", string(output))
}

// Try to install MySQL server (with timeout)
installCtx, installCancel := context.WithTimeout(ctx, 60*time.Second)
defer installCancel()
cmd := exec.CommandContext(installCtx, "sudo", "apt-get", "install", "-y", "-qq", "mysql-server")
// Try to install MySQL server (with 60 second timeout using Linux timeout command)
cmd := exec.Command("sudo", "timeout", "60", "apt-get", "install", "-y", "-qq", "mysql-server")
cmd.Env = append(os.Environ(), "DEBIAN_FRONTEND=noninteractive")
if output, err := cmd.CombinedOutput(); err != nil {
// If apt-get fails (no network or timeout), return error
Expand Down
Loading