Skip to content

fix(codegen/golang): handle go_struct_tag for db_type overrides #4055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleconroy merged 4 commits into from
Aug 12, 2025
Merged

fix(codegen/golang): handle go_struct_tag for db_type overrides #4055

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08c808d
fix(codegen/golang): handle `go_struct_tag` for `db_type` overrides
andrewmbenton Aug 11, 2025
9c42b32
update tests
andrewmbenton Aug 11, 2025
90dd838
properly handle nullable and other db_type match parameters
andrewmbenton Aug 11, 2025
5611a92
and update tests
andrewmbenton Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(codegen/golang): handle go_struct_tag for db_type overrides 
Resolves #3143
  • Loading branch information
@andrewmbenton
andrewmbenton committed Aug 11, 2025
commit 08c808de3860405e40350121950bc249a8c3bf13
10 changes: 10 additions & 0 deletions internal/codegen/golang/go_type.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,16 @@ func addExtraGoStructTags(tags map[string]string, req *plugin.GenerateRequest, o
if oride.GoType.StructTags == nil {
continue
}
if oride.DbType != "" {
columnType := sdk.DataType(col.Type)
if columnType != oride.DbType {
continue
}
for k, v := range oride.GoType.StructTags {
tags[k] = v
}
continue
}
if !override.Matches(col.Table, req.Catalog.DefaultSchema) {
// Different table.
continue
Expand Down