Skip to content

fix(docs): Add ordering warning for numeric goose migration#3481

Merged
kyleconroy merged 1 commit into
sqlc-dev:mainfrom
rob2244:fix-3444
Aug 5, 2024
Merged

fix(docs): Add ordering warning for numeric goose migration#3481
kyleconroy merged 1 commit into
sqlc-dev:mainfrom
rob2244:fix-3444

Conversation

@rob2244
Copy link
Copy Markdown
Contributor

@rob2244 rob2244 commented Jul 7, 2024

When using Goose with numeric migrations, if the migration files aren't in lexographic order SQLC parses them in the wrong order. This is similar to the issue that occurs with golang-migrate. This pr documents this behaviour.

When using Goose with numeric migrations, if the migration files aren't in
lexographic order SQLC parses them in the wrong order. This is similar to the issue that occurs
with golang-migrate. This pr documents this behaviour.
@rob2244
Copy link
Copy Markdown
Contributor Author

rob2244 commented Jul 7, 2024

Closes #3444

@kyleconroy
Copy link
Copy Markdown
Collaborator

Thanks Rob. Longer term I do want to make sure we fix this. It may involve embedding goose inside sqlc itself. We'll see!

@kyleconroy kyleconroy merged commit c004851 into sqlc-dev:main Aug 5, 2024
@noahjamison
Copy link
Copy Markdown

@rob2244 @kyleconroy

I found a quick fix (see link below) that might be worth adding to the docs until the root problem gets solved. I'd be happy to spin up a quick PR if you think it'd be helpful for others!

#3444 (comment)

alfonsodev pushed a commit to ExponentiaTeam/sqlc that referenced this pull request Oct 13, 2025
…#3481)

When using Goose with numeric migrations, if the migration files aren't in
lexographic order SQLC parses them in the wrong order. This is similar to the issue that occurs
with golang-migrate. This pr documents this behaviour.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants