postgresql: harden two-phase xid SQL literal quoting#13225
Closed
c4tzzz wants to merge 1 commit intosqlalchemy:mainfrom
Closed
postgresql: harden two-phase xid SQL literal quoting#13225c4tzzz wants to merge 1 commit intosqlalchemy:mainfrom
c4tzzz wants to merge 1 commit intosqlalchemy:mainfrom
Conversation
Member
|
Hi, We require an issue for these kind of PRs, that also shows the issue. |
Author
|
If this isn't relevant, I'll close the request. Have a good day. |
Member
|
it's not that it's not relevant, it's that we have a process that should be followed for contributions that aren't just simple typo/docs/etc fixes. This doesn't classify as a short code fix. In any case I'll open an issue as reminder so that a better analysis could be done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a defensive hardening change for PostgreSQL two-phase transaction SQL string construction.
It replaces direct %s interpolation of xid in:
with SQL-quoted literals using existing internal helpers.
Updated locations:
Tests added:
This is intended as a hardening/defensive coding improvement; no behavior change is expected for normal valid xid
values.
Checklist
This pull request is: