Repository navigation
Conversation
Kafka captures the SslBundle instance once, in SslBundleSslEngineFactory.configure(), and never asks for it again. DefaultSslBundleRegistry replaces the instance registered for a name when the bundle is reloaded, so a client configured at startup keeps presenting the key material it was given then. Rotated certificates only take effect after a restart. PropertiesKafkaConnectionDetails now adapts each configured bundle name to a LiveSslBundle, which resolves the currently registered bundle on every access instead of capturing it. The reference Kafka holds can no longer go stale, and the next connection uses the latest key material. Established connections are left alone. Bundles are cached per name so that repeated lookups return the same instance, leaving SslBundleSslEngineFactory.shouldBeRebuilt unaffected, and so that exactly one update handler is registered per bundle. Registering that handler also validates the name, so an unknown bundle keeps failing at startup rather than on first connection. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Henning Kvinnesland <henning.kvinnesland@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kafka captures the SslBundle instance once, in
SslBundleSslEngineFactory.configure(), and never asks for it again. DefaultSslBundleRegistry replaces the instance registered for a name when the bundle is reloaded, so a client configured at startup keeps presenting the key material it was given then. Rotated certificates only take effect after a restart.
PropertiesKafkaConnectionDetails now adapts each configured bundle name to a LiveSslBundle, which resolves the currently registered bundle on every access instead of capturing it. The reference Kafka holds can no longer go stale, and the next connection uses the latest key material. Established connections are left alone.
Bundles are cached per name so that repeated lookups return the same instance, leaving SslBundleSslEngineFactory.shouldBeRebuilt unaffected, and so that exactly one update handler is registered per bundle. Registering that handler also validates the name, so an unknown bundle keeps failing at startup rather than on first connection.