#6832 configurable PgVectorStore distance type - #6864
Open
martin-grofcik wants to merge 3 commits into
Open
Conversation
Signed-off-by: martin-grofcik <mgrofcik@gmail.com>
Signed-off-by: martin-grofcik <mgrofcik@gmail.com>
Member
|
@martin-grofcik Thanks for the PR! Could you apply the changes for the autoconfiguration module as well? |
Signed-off-by: martin-grofcik <mgrofcik@gmail.com>
| "vector_cosine_ops", | ||
| "SELECT *, embedding <=> ? AS distance FROM %s WHERE embedding <=> ? < ? %s ORDER BY distance LIMIT ? "); | ||
|
|
||
| public static final Map<PgDistanceType, VectorStoreSimilarityMetric> SIMILARITY_TYPE_MAPPING = Map.of( |
| * Defaults to CosineDistance. But if vectors are normalized to length 1 (like OpenAI | ||
| * embeddings), use inner product (NegativeInnerProduct) for best performance. | ||
| */ | ||
| public enum PgDistanceType { |
Member
There was a problem hiding this comment.
Removing public enum would be a breaking change. Instead we should deprecate.
| return switch (properties.getDistanceType()) { | ||
| case "EUCLIDEAN_DISTANCE" -> PgVectorStore.EUCLIDEAN_DISTANCE; | ||
| case "NEGATIVE_INNER_PRODUCT" -> PgVectorStore.NEGATIVE_INNER_PRODUCT; | ||
| default -> PgVectorStore.COSINE_DISTANCE; |
Member
There was a problem hiding this comment.
While I agree that the default should be consine_distance, there is no error check on the valid distance type value as any invalid one can lead to the default value as well. Please consider adding a validation before setting the default value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making PgDistanceType configurable enables queries extensions. (e.g. to implement access based on identities)