Right now, I've placed all new common interfaces in an interfaces subfolder. We could move IModelObject.java and IPlaylistItem.java in there as well for consistency (there are breaking changes in v10 anyway). Or don't do it for backward compatibility. I'm undecided about this one, so let me know :)

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.84%. Comparing base (a069569) to head (57276dd).
⚠️ Report is 6 commits behind head on beta.

@@            Coverage Diff            @@
##               beta     #457   +/-   ##
=========================================
  Coverage     49.84%   49.84%           
  Complexity      582      582           
=========================================
  Files           243      243           
  Lines          8626     8626           
  Branches       1054     1054           
=========================================
  Hits           4300     4300           
  Misses         3526     3526           
  Partials        800      800           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

IEpisode and ITrack furthermore share similarities which could be unified inside IPlaylistItem, however they currently do not share the same method names:

• getAudioPreviewUrl vs getPreviewUrl
• getExplicit vs getIsExplicit
• getPlayable vs getIsPlayable

However, renaming these would also be a breaking change…

As this PR targets beta, breaking changes are ok. As long as this repo's source code stays in sync with Spotify's api docs, I'm fine with such changes!

As long as this repo's source code stays in sync with Spotify's api docs, I'm fine with such changes!

@dargmuesli thanks for your reply :)

Let me ask a follow up question:

In the Spotify docs, it's explicit and is_playable for Episode and Track, while one uses preview_url and the other uses audio_preview_url. Exactly sticking to the API would also mean that we cannot have a common preview URL method.

Track.java currently uses getIsPlayable, getIsExplicit, getPreviewUrl, Episodes has getPlayable, getExplicit and getAudioPreviewUrl. Personally I would say, let's use the ones we already have for Tracks as they are probably used more and rename the Episode counterparts (although this would not be 100% in line with the official Spotify API doc).

But as I don't really like the felling to break code intentionally and to do not block the remaining PR, I would suggest not unifying these methods for now. Let me know whether you have a preference, despite that the PR would be ready for review.

I think I've used the is prefix uniformly earlier and then have stuck to the api spec naming in more recent additions. Yes, that should be aligned, in a separate PR.

For now, I've added a minor change that should allow for types to be more specific and not be reduced to iHasTotal only. Please check and let me know if you're fine with that!

Initially I actually had a generic version IPlaylist<T>, which however caused the type of getItems to get unusable. Therefore, I switched to IHasTotal, however your T extends IHasTotal solution is even more elegant :)

Version 10.0.0-RC3 should be available shortly.