Skip to content
This repository was archived by the owner on Apr 20, 2026. It is now read-only.

Fix coverage upload on main builds#96

Merged
dziemba merged 1 commit into
masterfrom
fix-coverage-upload
May 9, 2022
Merged

Fix coverage upload on main builds#96
dziemba merged 1 commit into
masterfrom
fix-coverage-upload

Conversation

@dziemba
Copy link
Copy Markdown
Member

@dziemba dziemba commented May 9, 2022

We need to enable the coverage profile in the main build/publish maven
step, otherwise codecov has nothing to upload.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2022

Codecov Report

Merging #96 (b8855d3) into master (94db54c) will decrease coverage by 0.42%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master      #96      +/-   ##
============================================
- Coverage     70.20%   69.77%   -0.43%     
- Complexity      222      223       +1     
============================================
  Files            36       36              
  Lines           866      857       -9     
  Branches         36       35       -1     
============================================
- Hits            608      598      -10     
- Misses          233      234       +1     
  Partials         25       25              
Impacted Files Coverage Δ
.../com/spotify/github/opencensus/OpenCensusSpan.java 60.00% <0.00%> (ø)
...fy/github/v3/exceptions/RequestNotOkException.java 57.14% <50.00%> (+2.59%) ⬆️
...thub/v3/repos/BranchProtectionUrlDeserializer.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33923fe...b8855d3. Read the comment docs.

We need to enable the `coverage` profile in the main build/publish maven
step, otherwise codecov has nothing to upload.
@dziemba dziemba force-pushed the fix-coverage-upload branch from 3497c13 to b8855d3 Compare May 9, 2022 09:01
Copy link
Copy Markdown

@lufsariskogen lufsariskogen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up!

@dziemba dziemba merged commit 7475d79 into master May 9, 2022
@dziemba dziemba deleted the fix-coverage-upload branch May 9, 2022 09:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants