Skip to content
This repository was archived by the owner on Apr 20, 2026. It is now read-only.

feat: add page & per_page to PullRequestParameters #50

Merged
backuitist merged 1 commit into from
Feb 1, 2021
Merged

feat: add page & per_page to PullRequestParameters #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/main/java/com/spotify/github/v3/prs/requests/PullRequestParameters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,5 +58,16 @@ public interface PullRequestParameters extends Parameters {
*/
Optional<String> direction();

/**
* Results per page (max 100)
*/
@SuppressWarnings("checkstyle:methodname")
Optional<Integer> per_page();

/**
* Page number of the results to fetch.
*/
Optional<Integer> page();

/** Serialize declared non-Object methods as key=value joined by & */
}
5 changes: 4 additions & 1 deletion src/test/java/com/spotify/github/v3/prs/requests/PullRequestParametersTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,14 @@ public void testFullSerialize() {
.head("bogus-head")
.sort("bogus-sort")
.state("bogus-state")
.page(2)
.per_page(5)
.build();

assertThat(
params.serialize(),
is(
"base=bogus-base&direction=bogus-direction&head=bogus-head&sort=bogus-sort&state=bogus-state"));
"base=bogus-base&direction=bogus-direction&head=bogus-head&page=2" +
"&per_page=5&sort=bogus-sort&state=bogus-state"));
}
}