Skip to content
This repository was archived by the owner on Apr 20, 2026. It is now read-only.

Fix the delete reference endpoint#31

Merged
henriquetruta merged 1 commit into
spotify:masterfrom
Lirick:fix-delete-ref
Aug 18, 2020
Merged

Fix the delete reference endpoint#31
henriquetruta merged 1 commit into
spotify:masterfrom
Lirick:fix-delete-ref

Conversation

@Lirick
Copy link
Copy Markdown
Contributor

@Lirick Lirick commented Aug 18, 2020

:ref shouldn't include refs/ unless it is a create reference (or github is returning it https://developer.github.com/v3/git/refs/). Now the library will handle both cases

Allow branch + tag delete to either use fully specified names or only the usual name

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 18, 2020

Codecov Report

Merging #31 into master will increase coverage by 0.87%.
The diff coverage is 91.17%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #31      +/-   ##
============================================
+ Coverage     65.37%   66.25%   +0.87%     
- Complexity      166      175       +9     
============================================
  Files            28       29       +1     
  Lines           699      723      +24     
  Branches         28       29       +1     
============================================
+ Hits            457      479      +22     
- Misses          221      223       +2     
  Partials         21       21              
Impacted Files Coverage Δ Complexity Δ
...a/com/spotify/github/v3/clients/GitDataClient.java 75.00% <57.14%> (-5.00%) 9.00 <3.00> (+2.00) ⬇️
...va/com/spotify/github/v3/clients/GitHubClient.java 69.15% <100.00%> (+0.31%) 41.00 <0.00> (ø)
.../com/spotify/github/v3/clients/JwtTokenIssuer.java 100.00% <100.00%> (ø) 6.00 <3.00> (+3.00)
...ava/com/spotify/github/v3/clients/PKCS1PEMKey.java 100.00% <100.00%> (ø) 4.00 <4.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55485ca...3189ffa. Read the comment docs.

@henriquetruta henriquetruta merged commit b0b83c9 into spotify:master Aug 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants