Skip to content
This repository was archived by the owner on Apr 20, 2026. It is now read-only.

Add repository_dispatch endpoint#186

Merged
ebk45 merged 12 commits into
spotify:masterfrom
ajmalab:add-dispatches-endpoint
Jun 13, 2024
Merged

Add repository_dispatch endpoint#186
ebk45 merged 12 commits into
spotify:masterfrom
ajmalab:add-dispatches-endpoint

Conversation

@ajmalab
Copy link
Copy Markdown
Contributor

@ajmalab ajmalab commented May 8, 2024 •
edited
Loading

Adding support for the /repos/{owner}/{repo}/dispatches endpoint that allows us to dispatch custom webhook events from repositories to trigger workflows. See more here: https://docs.github.com/en/rest/repos/repos?apiVersion=2022-11-28#create-a-repository-dispatch-event

ajmalab added 10 commits May 9, 2024 00:43
@ajmalab
add repositry_dispatch endpoint
804e1ee 
Signed-off-by: Ajmal Kottilingal <ajmal.kottilingal@transferwise.com>
@ajmalab
remove unused import
44944b0 
Signed-off-by: Ajmal Kottilingal <ajmal.kottilingal@transferwise.com>
@ajmalab
remove unused import
7f12a4a 
Signed-off-by: Ajmal Kottilingal <ajmal.kottilingal@transferwise.com>
@ajmalab
change order of owner and repo in path
91159fa 
Signed-off-by: Ajmal Kottilingal <ajmal.kottilingal@transferwise.com>
@ajmalab
make param final
81791f2 
Signed-off-by: Ajmal Kottilingal <ajmal.kottilingal@transferwise.com>
@ajmalab
add header
d50a983 
Signed-off-by: Ajmal Kottilingal <ajmal.kottilingal@transferwise.com>
@ajmalab
update comment
f71c232 
Signed-off-by: Ajmal Kottilingal <ajmal.kottilingal@transferwise.com>
@ajmalab
change access of method
4e36959 
Signed-off-by: Ajmal Kottilingal <ajmal.kottilingal@transferwise.com>
@ajmalab
remove nullable annotation
ec830f4 
Signed-off-by: Ajmal Kottilingal <ajmal.kottilingal@transferwise.com>
@ajmalab
remove nullable import
4c8cb1c 
Signed-off-by: Ajmal Kottilingal <ajmal.kottilingal@transferwise.com>
@ajmalab ajmalab marked this pull request as draft May 9, 2024 12:48
@ajmalab ajmalab marked this pull request as ready for review May 9, 2024 12:48
@ajmalab
Copy link
Copy Markdown
Contributor Author

ajmalab commented May 9, 2024

@felix-seifert or @Abhi347 perhaps for a review? 😄

ebk45
ebk45 reviewed May 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ebk45 ebk45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! Code changes look good but we'd appreciate if any new endpoints have tests written for them where possible.

Abhi347
Abhi347 reviewed May 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Abhi347 Abhi347 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as @ebk45 mentioned! This needs tests

@ajmalab
Copy link
Copy Markdown
Contributor Author

ajmalab commented May 9, 2024 •
edited
Loading

I did consider tests, but the response for that endpoint is always a 204 with no body (similar to the editComment and deleteComment methods). Unsure what I'd be testing (perhaps I can simply check for a 204 no body response?). Happy to take suggestions.

@ebk45
Copy link
Copy Markdown
Contributor

ebk45 commented May 10, 2024

I did consider tests, but the response for that endpoint is always a 204 with no body (similar to the editComment and deleteComment methods). Unsure what I'd be testing (perhaps I can simply check for a 204 no body response?). Happy to take suggestions.

Hi @ajmalab, yeah exactly. It's mostly for safety in case this code where to change. Even testing something as simple as a 204 response is still valuable. You'll see similar tests in RepositoryClientTest.java.

ajmalab added 2 commits May 10, 2024 14:53
@ajmalab
add test
464f27d 
Signed-off-by: Ajmal Kottilingal <ajmal.kottilingal@transferwise.com>
@ajmalab
remove unused import
822beaf 
Signed-off-by: Ajmal Kottilingal <ajmal.kottilingal@transferwise.com>
@ajmalab
Copy link
Copy Markdown
Contributor Author

ajmalab commented May 10, 2024 •
edited
Loading

@ebk45 @Abhi347 Added a test, please do let me know if you require further changes 😄

@ajmalab
Copy link
Copy Markdown
Contributor Author

ajmalab commented May 16, 2024

Could I get a review please 🙏 @ebk45 or @Abhi347 perhaps?

@ebk45 ebk45 merged commit 8a0fa55 into spotify:master Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@Abhi347 Abhi347 Abhi347 left review comments

@ebk45 ebk45 ebk45 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ajmalab @ebk45 @Abhi347