add search commit api#147
Conversation
ebk45
left a comment
There was a problem hiding this comment.
Hi there, I've been taking a look at your PR and the code changes look good. Are you able to please write a unit test to cover your added functionality?
The SearchClient already has the tests scaffolded here: https://github.com/spotify/github-java-client/blob/master/src/test/java/com/spotify/github/v3/clients/SearchClientTest.java
Feel free to add me as a reviewer when this is good to go and I'll take a look.
|
We apologise for taking so long to get eyes on this PR, we haven't been able to maintain this library to the standard we would have liked to but this will be changing in the new year. If you could please get this rebased and we'll be prioritising all open PRs ready for review. Thanks! Ellie |
|
Hello, As this PR is now stale and we've not had any new activity on it, we've decided to close it so we can keep track of active/more recent changes. We will leave the branch untouched in case you would like to reopen and rebase. Thanks! Ellie |
Added searching by commit.