Skip to content
This repository was archived by the owner on Apr 20, 2026. It is now read-only.

Validate field lengths in checks annotations + actions#109

Merged
dziemba merged 1 commit into
masterfrom
checks-limits
Aug 3, 2022
Merged

Validate field lengths in checks annotations + actions#109
dziemba merged 1 commit into
masterfrom
checks-limits

Conversation

@dziemba
Copy link
Copy Markdown
Member

@dziemba dziemba commented Aug 3, 2022

Automatically validates the maximum length of properties.

GitHub does not validate these properly on their side (at least in GHE 3.2)
and returns 5xx HTTP responses instead. To avoid that, let's validate the data
in this client library.

The values are taken from the official GitHub documentation.
Other fields might also have restrictions that are undocumented.
We might add validation for these later.

Automatically validates the maximum length of properties.

GitHub does not validate these properly on their side (at least in GHE 3.2)
and returns 5xx HTTP responses instead. To avoid that, let's validate the data
in this client library.

The values are taken from the official GitHub documentation.
Other fields might also have restrictions that are undocumented.
We might add validation for these later.
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 3, 2022

Codecov Report

Merging #109 (6383919) into master (d3a7af0) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #109      +/-   ##
============================================
+ Coverage     72.82%   73.06%   +0.24%     
- Complexity      237      245       +8     
============================================
  Files            37       39       +2     
  Lines           872      880       +8     
  Branches         35       39       +4     
============================================
+ Hits            635      643       +8     
  Misses          212      212              
  Partials         25       25              
Impacted Files Coverage Δ
.../java/com/spotify/github/v3/checks/Annotation.java 100.00% <100.00%> (ø)
...a/com/spotify/github/v3/checks/CheckRunAction.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Contributor

@sathish-kumar-subramani sathish-kumar-subramani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯

@dziemba dziemba merged commit c04bf3e into master Aug 3, 2022
@dziemba dziemba deleted the checks-limits branch August 3, 2022 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants