Skip to content

A lot of fixes#60

Merged
madhadron merged 22 commits intodevelopfrom
fross/review-fixes
Dec 1, 2012
Merged

A lot of fixes#60
madhadron merged 22 commits intodevelopfrom
fross/review-fixes

Conversation

@madhadron
Copy link
Copy Markdown

This might be easier to review as individual commits, since they're mostly fairly coherent hunks of work.

Frederick Ross added 22 commits November 27, 2012 14:31
- Added a note that Confs as been renamed to Configurations in CHANGELOG.md.
- Entity.refresh no longer tries to interpret HTTPErrors, and just lets them bubble up. Fixed test_delete tests in test_input,
  test_role, test_saved_search, and test_user to expect HTTPError instead of EntityDeletedException. Deleted EntityDeletedException
  since it is not longer used.
- Fixed namespace logic in Entity._proper_namespace to draw on the entity's own namespace before the service's namespace.
- Moved AmbiguousReferenceException throwing from _load_state in Entity to _load_atom_entry (where it should be).
- Fixed doctoring of Service.search to indicate that it returns a Job, not the results of a oneshot search.
- Edited a comment that was too Freddian for public consumption.
- Moved URL-unquoting of links from refresh to read on Entity, and made it a UrlEncoded step instead of unencoding them.
Configurations.delete now throws IllegalOperationException immediately.
Docstrings on Configurations no longer refer to stanzas.
Updated changelog saying that Confs has been renamed to Configurations
and ConfFile to ConfigurationFile.

Also, make Entity.__getitem__ pass no namespace if none is provided.
Fixed conf.py the example to submit a dict instead of a string.
Added armor to the test in test_examples that tests conf.py.
Removed the unit test that was testing Stanza.submit with a string
as an argument.
Rename Indexes.default to Indexes.get_default.
Removed the enable and disable methods on Index, since they weren't doing anything
that the Entity method wasn't already doing.
Moved reenabling the index at the end of Index.clean to before throwing an exception
if the clean didn't leave the index empty.
Everything now must use the in operator instead.
Updated the CHANGELOG, fixed two examples that depend on contains,
and one test.
…dict-like contexts.

Removed wrapper exceptions that were no longer used.
Fixed the unit tests to expect HTTPErrors.
Now any attempt to update restrictToHost on an existing input immediately throws
an IllegalOperationException. If there is a restrictToHost parameter, it is set internally
to be updated so that Splunk 5.0 and 5.0.1 don't reset the restrictToHost parameter
on the input.
Updated the test suite correspondingly.
…irst.

The only breaking change is Inputs.create, which has been noted in the change log.
Removed a couple of UNDONE comments.
Removed Job.refresh(). Rewrite Job.is_ready().
Moved two exceptions to the top of the file with the other exceptions.
Made a comment more understandable.
Added tests for Entity._proper_namespace.
…reading empty results sets from searches to test_results.py.
Comment thread CHANGELOG.md
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this actually a change from a released version? I thought we decided it was already like this.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was kind before name in create on the beta release.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it seems :) my bad.

@itay
Copy link
Copy Markdown
Contributor

itay commented Nov 30, 2012

some minor comments.

@madhadron madhadron merged commit 75ae214 into develop Dec 1, 2012
mateusz834 pushed a commit that referenced this pull request Apr 15, 2026
* Add ai_modinput_app

* Finish work on ai_modinput_input

* PR fixes #1

* PR fixes #2

* PR fixes #3

* Remove unnecessary `--force-rebuild` flag from `make docker-up`

* PR fixes #n

* Add missing newline

* Fix README

* Finish fixing ai_modinput_app

* PR fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants